Minor changes to Node and Java publishing (#1008)

- Latest Node LTS ships with a version of npm recent enough to support
  trusted signing to no need to explicitly install latest npm.
- No longer publish unstable/snapshot versions of Node and Java
  artifacts on every push.

Signed-off-by: Mark S. Lewis <[email protected]>

Author: bestbeforetoday

.github/scripts/maven_publish_release.sh renamed to .github/scripts/maven_publish.sh

@@ -2,7 +2,7 @@
 
 set -eu -o pipefail
 
-PUBLISH_PROFILE="${1:?}"
+PUBLISH_PROFILE="${1:?Publish profile must be provided.}"
 
 POM_VERSION=$(mvn org.apache.maven.plugins:maven-help-plugin:evaluate -Dexpression=project.version -q -DforceStdout)
 PUBLISH_VERSION="${POM_VERSION%%-*}"

.github/scripts/maven_publish_snapshot.sh

@@ -56,49 +56,3 @@ jobs:
       - name: Deploy to GitHub Pages
         id: deployment
         uses: actions/deploy-pages@d6db90164ac5ed86f2b6aed7e0febac5b3c0c03e # v4.0.5
-
-  publish-node:
-    needs: build
-    name: Publish Node package to GitHub Packages
-    runs-on: ubuntu-24.04
-    permissions:
-      contents: read
-      packages: write
-    concurrency:
-      group: npm-pkg
-      cancel-in-progress: false
-    steps:
-      - uses: actions/checkout@1af3b93b6815bc44a9784bd300feb67ff0d1eeb3 # v6.0.0
-      - uses: actions/setup-node@2028fbc5c25fe9cf00d9f06a71cc4710d4507903 # v6.0.0
-        with:
-          node-version: "lts/*"
-          registry-url: "https://npm.pkg.github.com"
-      - name: Build
-        run: make build-node
-      - name: Publish
-        env:
-          NODE_AUTH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
-        run: ${{ github.workspace }}/.github/scripts/npm_publish.sh unstable
-        working-directory: node
-
-  publish-java:
-    needs: build
-    name: Publish Java artifact to GitHub Packages
-    runs-on: ubuntu-24.04
-    permissions:
-      contents: read
-      packages: write
-    steps:
-      - uses: actions/checkout@1af3b93b6815bc44a9784bd300feb67ff0d1eeb3 # v6.0.0
-      - uses: actions/setup-java@dded0888837ed1f317902acf8a20df0ad188d165 # v5.0.0
-        with:
-          java-version: 25
-          distribution: temurin
-          cache: maven
-      - name: Publish
-        env:
-          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
-          MAVEN_GPG_KEY: ${{ secrets.OSSRH_GPG_SECRET_KEY }}
-          MAVEN_GPG_PASSPHRASE: ${{ secrets.OSSRH_GPG_SECRET_KEY_PASSWORD }}
-        run: ${{ github.workspace }}/.github/scripts/maven_publish_snapshot.sh
-        working-directory: java

.github/workflows/push.yml

@@ -25,9 +25,6 @@ jobs:
         with:
           node-version: "lts/*"
           registry-url: "https://registry.npmjs.org"
-      # Ensure npm 11.5.1 or later for trusted publishing support
-      - name: Update npm
-        run: npm install -g npm@latest
       - name: Build
         run: make build-node
       - name: Publish
@@ -53,7 +50,7 @@ jobs:
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
           MAVEN_GPG_KEY: ${{ secrets.OSSRH_GPG_SECRET_KEY }}
           MAVEN_GPG_PASSPHRASE: ${{ secrets.OSSRH_GPG_SECRET_KEY_PASSWORD }}
-        run: ${{ github.workspace }}/.github/scripts/maven_publish_release.sh github
+        run: ${{ github.workspace }}/.github/scripts/maven_publish.sh github
         working-directory: java
 
   publish-java-central:
@@ -76,5 +73,5 @@ jobs:
           MAVENCENTRAL_PASSWORD: ${{ secrets.MAVENCENTRAL_PASSWORD }}
           MAVEN_GPG_KEY: ${{ secrets.OSSRH_GPG_SECRET_KEY }}
           MAVEN_GPG_PASSPHRASE: ${{ secrets.OSSRH_GPG_SECRET_KEY_PASSWORD }}
-        run: ${{ github.workspace }}/.github/scripts/maven_publish_release.sh central
+        run: ${{ github.workspace }}/.github/scripts/maven_publish.sh central
         working-directory: java