Enable the SDK to choose the subject DID when accepting a credential offer.

[mineme0110]

Proposed feature

Currently, the subject DID is created and used automatically when accepting the offer, but the process is not transparent to the user, and there is no option to choose the subject DID

sdk-ts/src/plugins/internal/oea/jwt/CredentialOffer.ts

Lines 11 to 53 in ae3987f

	export class CredentialOffer extends Plugins.Task<Args> {
	async run(ctx: Plugins.Context) {
	const offer = this.args.offer;
	// [ ] https://github.com/hyperledger-identus/sdk-ts/issues/363 use CreatePrismDID
	// CreatePrismDID needs updating to accept keytypes (both secp here)
	const getIndexTask = new PrismKeyPathIndexTask({});
	const index = await ctx.run(getIndexTask);
	const masterSk = await ctx.Apollo.createPrivateKey({
	[Domain.KeyProperties.curve]: Domain.Curve.SECP256K1,
	[Domain.KeyProperties.index]: index,
	[Domain.KeyProperties.seed]: Buffer.from(ctx.Seed.value).toString("hex"),
	});
	const authSk = await ctx.Apollo.createPrivateKey({
	[Domain.KeyProperties.curve]: Domain.Curve.SECP256K1,
	[Domain.KeyProperties.index]: index + 1,
	[Domain.KeyProperties.seed]: Buffer.from(ctx.Seed.value).toString("hex"),
	});
	const did = await ctx.Castor.createPrismDID(
	masterSk.publicKey(),
	[],
	[authSk.publicKey()]
	);
	await ctx.Pluto.storeDID(did, [masterSk, authSk]);
	// ODOT
	const payload = {
	aud: [offer.options.domain],
	nonce: offer.options.challenge,
	vp: {
	"@context": ["https://www.w3.org/2018/presentations/v1"],
	type: ["VerifiablePresentation"],
	},
	};
	const signedJWT = await ctx.JWT.signWithDID(did, payload);
	return Payload.make(OEA.PRISM_JWT, signedJWT);

Feature description

Feature: User control over subject DID selection

As an SDK user,
I want to have control over the subject DID used when accepting a credential offer,
So that I can choose which DID to use instead of relying on an automatically created one.

Scenario: Accepting a credential offer with a chosen subject DID
Given I am using the SDK
When I receive a credential offer
Then I should have the option to select a subject DID before accepting the offer
And the process should be transparent to me.

Anything else?

No response

[mineme0110]

@elribonazo @yshyn-iohk

[robertocarvajal]

I understand wanting the flexibility, but creating new DIDs for different Credential Offers is a privacy preserving feature, meaning that, if you reuse your DID on multiple credentials, that opens up a correlation/tracking vector to the holder. It is discouraged to reuse DIDs because of this, another way of saying this is that your Identity should not be traceable back to a single identifier.

[elribonazo]

That is correct, i think it was discussed on community calls to the reasoning behind it, etc. Shall we close this?