Skip to content

Commit fb66126

Browse files
authored
fix: remove play button and time picker from markdown tab (#1141)
This PR fixes: HDX-1641 The Linear issue only mentions: > The Run button on the Markdown form doesn't do anything However, in **Charts Explorer → Markdown**, the time picker also wasn’t working. I’ve removed it as well. <img width="2681" height="2048" alt="image" src="https://github.com/user-attachments/assets/6f6b7fc5-544f-43e2-ab9d-05894f83e8d6" />
1 parent 042e359 commit fb66126

2 files changed

Lines changed: 17 additions & 9 deletions

File tree

‎.changeset/fair-eagles-explode.md‎

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
"@hyperdx/app": patch
3+
---
4+
5+
fix: remove play button and time picker from markdown tab

‎packages/app/src/components/DBEditTimeChartForm.tsx‎

Lines changed: 12 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -849,7 +849,8 @@ export default function EditTimeChartForm({
849849
)}
850850
</Flex>
851851
<Flex gap="sm" my="sm" align="center" justify="end">
852-
{setDisplayedTimeInputValue != null &&
852+
{activeTab !== 'markdown' &&
853+
setDisplayedTimeInputValue != null &&
853854
displayedTimeInputValue != null &&
854855
onTimeRangeSearch != null && (
855856
<TimePicker
@@ -866,14 +867,16 @@ export default function EditTimeChartForm({
866867
{activeTab === 'time' && (
867868
<GranularityPickerControlled control={control} name="granularity" />
868869
)}
869-
<Button
870-
variant="outline"
871-
type="submit"
872-
color="green"
873-
onClick={onSubmit}
874-
>
875-
<i className="bi bi-play"></i>
876-
</Button>
870+
{activeTab !== 'markdown' && (
871+
<Button
872+
variant="outline"
873+
type="submit"
874+
color="green"
875+
onClick={onSubmit}
876+
>
877+
<i className="bi bi-play"></i>
878+
</Button>
879+
)}
877880
</Flex>
878881
</Flex>
879882
{!queryReady && activeTab !== 'markdown' ? (

0 commit comments

Comments
 (0)