refactor(connect): handroll simple Either in lieu of crocks. adjust deno permissions

Author: TillaTheHun0

.github/workflows/connect.yml

@@ -33,6 +33,7 @@ jobs:
       - name: ⚡ Run Tests
         run: |
           cd packages/connect
+          deno install
           deno task test
         env:
           CI: true

packages/connect/Makefile

@@ -6,7 +6,7 @@ clean:
 # to copy the types from the output of deno2node into the microbundle output folder in order to get types working
 # a total hack to get the types working
 to-node:
-	@deno run --no-check --allow-read --allow-write \
+	@deno run --no-check --allow-read --allow-write --allow-env --allow-import \
   		https://deno.land/x/[email protected]/src/cli.ts ./tsconfig.to-node.jsonc && \
 	yarn build && \
 	echo "copying types..." && find ./to-node -mindepth 1 -depth -name '*.d.ts' -exec cp --parents \{\} ./dist \; && \

packages/connect/deno.json

@@ -1,6 +1,6 @@
 {
   "tasks": {
-    "cache": "deno cache --lock=deno.lock --lock-write deno/deps.deno.ts deno/dev_deps.ts",
+    "cache": "deno cache --lock=deno.lock -A deno/deps.deno.ts deno/dev_deps.ts",
     "test": "deno lint && deno fmt && deno test -A --no-lock --no-check deno/tests",
     "test:integration": "make test-integration",
     "to-node": "make clean to-node"

packages/connect/deno.lock

@@ -5,9 +5,6 @@ export { default as ms } from 'npm:ms@^2'
 
 // @deno-types="npm:@types/ramda@^0.28.23"
 export * as R from 'npm:[email protected]'
-// deno-lint-ignore ban-ts-comment
-// @ts-ignore
-export { default as crocks } from 'npm:[email protected]'
 
 /**
  * See deps.node.ts for shims of below

packages/connect/deno/deps.deno.ts

@@ -10,9 +10,6 @@
 export * as R from 'ramda'
 export { default as ms } from 'ms'
 
-// @ts-nocheck crocks types are not up to date, and we don't use them anyway
-export { default as crocks } from 'crocks'
-
 import { SignJWT } from 'jose'
 import { BinaryToTextEncoding, createHmac, createSecretKey } from 'crypto'
 import { lookup } from 'mime-types'

packages/connect/deno/deps.node.ts

@@ -0,0 +1,48 @@
+export class Either {
+  constructor(value) {
+    this.value = value
+  }
+
+  static Left(value) {
+    return new _Left(value)
+  }
+
+  static Right(value) {
+    return new _Right(value)
+  }
+
+  isLeft() {
+    return this instanceof _Left
+  }
+
+  isRight() {
+    return this instanceof _Right
+  }
+
+  map(fn) {
+    return this.isRight() ? Either.Right(fn(this.value)) : this
+  }
+
+  chain(fn) {
+    return this.isRight() ? fn(this.value) : this
+  }
+
+  either(leftFn, rightFn) {
+    return this.isLeft() ? leftFn(this.value) : rightFn(this.value)
+  }
+}
+
+class _Left extends Either {
+  constructor(value) {
+    super(value)
+  }
+}
+
+class _Right extends Either {
+  constructor(value) {
+    super(value)
+  }
+}
+
+export const Right = Either.Right
+export const Left = Either.Left

packages/connect/deno/utils/either.js

@@ -1,6 +1,7 @@
 // deno-lint-ignore-file ban-ts-comment
-import { crocks, hmac, ms, R } from '../deps.deno.ts'
+import { hmac, ms, R } from '../deps.deno.ts'
 import { Result } from '../types.ts'
+import { Left, Right } from './either.js'
 const {
   assoc,
   compose,
@@ -12,7 +13,6 @@ const {
   path,
   identity,
 } = R
-const { of, Left, Right } = crocks.Either
 
 interface Parsed {
   time: number
@@ -105,7 +105,7 @@ const handleSuccess = () => ({ ok: true })
  */
 export function createHyperVerify(secret: string, ttl?: string) {
   return function (signature: string, payload: unknown): Result {
-    return of({ input: { signature, payload }, secret, ttl })
+    return Right({ input: { signature, payload }, secret, ttl })
       .map(splitHyperSignature)
       .chain(createHmacSignature)
       .chain(compareSignatures)

packages/connect/deno/utils/hyper-verify.ts

@@ -26,7 +26,6 @@
     "build": "microbundle --tsconfig tsconfig.ci.jsonc"
   },
   "dependencies": {
-    "crocks": "^0.12.4",
     "jose": "^5.1.3",
     "mime-types": "^2.1.35",
     "ms": "^2.1.3",

packages/connect/package.json

@@ -1481,11 +1481,6 @@ cosmiconfig@^7.0.0:
     path-type "^4.0.0"
     yaml "^1.10.0"
 
-crocks@^0.12.4:
-  version "0.12.4"
-  resolved "https://registry.npmjs.org/crocks/-/crocks-0.12.4.tgz"
-  integrity sha512-paln6xJUrR9e/OWMFsyTi4dLyr+q99C5f7PQbGgSDHtwsfW0sCNZvnpHzvniI2dAE0uoBgeIP1Ukmme8Z0HxxA==
-
 css-declaration-sorter@^6.2.2:
   version "6.2.2"
   resolved "https://registry.npmjs.org/css-declaration-sorter/-/css-declaration-sorter-6.2.2.tgz"