Do not prefix internal constants in defined() and define() calls (#284)

Author: theofidry

specs/const/native-const.php

@@ -32,12 +32,19 @@
 
 $x = DIRECTORY_SEPARATOR;
 
+if (!defined('PATH_SEPARATOR')) {
+    define('PATH_SEPARATOR', "\n");
+}
+
 ----
 <?php
 
 namespace Humbug\Acme;
 
 $x = \DIRECTORY_SEPARATOR;
+if (!\defined('PATH_SEPARATOR')) {
+    \define('PATH_SEPARATOR', "\n");
+}
 
 PHP
     ,
@@ -51,13 +58,20 @@
 
 $x = DIRECTORY_SEPARATOR;
 
+if (!defined('PATH_SEPARATOR')) {
+    define('PATH_SEPARATOR', "\n");
+}
+
 ----
 <?php
 
 namespace Humbug\Acme;
 
 use const Humbug\Acme\DIRECTORY_SEPARATOR;
 $x = \Humbug\Acme\DIRECTORY_SEPARATOR;
+if (!\defined('PATH_SEPARATOR')) {
+    \define('PATH_SEPARATOR', "\n");
+}
 
 PHP
     ,

src/PhpParser/NodeVisitor/StringScalarPrefixer.php

@@ -180,8 +180,11 @@ private function prefixStringArg(String_ $string, Arg $parentNode): String_
             ;
         }
 
-        return ($this->whitelist->isSymbolWhitelisted($string->value, true)
+        return
+            (
+                $this->whitelist->isSymbolWhitelisted($string->value, true)
                 || $this->whitelist->isGlobalWhitelistedConstant($string->value)
+                || $this->reflector->isConstantInternal($string->value)
             )
             ? $string
             : $this->createPrefixedString($string)