Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop forcing C99 #81

Open
jbicha opened this issue Sep 26, 2018 · 4 comments
Open

Stop forcing C99 #81

jbicha opened this issue Sep 26, 2018 · 4 comments

Comments

@jbicha
Copy link

jbicha commented Sep 26, 2018

I propose that we revert b5436b49d7d

That commit forces the C99 standard to be used. Otherwise, it would build with C11 on newer distros. (There are some comments on the commit.)

jbicha referenced this issue Sep 26, 2018
We use C99 features (cd-spectrum.c:760), so need to explicitly enable them
in meson.build, as some compilers will not enable them automatically,
and will instead error when they encounter usage of C99.

Signed-off-by: Philip Withnall <[email protected]>
@hughsie
Copy link
Owner

hughsie commented Sep 26, 2018

Why do we want to build with C11? Are there any C11 features we use? Is there any performance increase? The original commit fixed a bug on old GCC versions.

@jbicha
Copy link
Author

jbicha commented Sep 26, 2018

Do you still support old GCC?

@hughsie
Copy link
Owner

hughsie commented Sep 26, 2018

I guess I support the GCC in rhel 7 -- although a lot of people use older gccs than that. I still don't really understand why you want to use C11 mode...

@jbicha
Copy link
Author

jbicha commented Sep 27, 2018

Ok, feel free to close if this is intentional. Sorry to bother you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants