Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alarm Code Context #161

Open
doctormo opened this issue Jan 19, 2024 · 1 comment
Open

Alarm Code Context #161

doctormo opened this issue Jan 19, 2024 · 1 comment

Comments

@doctormo
Copy link
Contributor

I'm reading through lcms2 to try and get things working and I notice that this code:

cmsSetAlarmCodes (alarm_codes);

Should not work, if lcms2 uses contexts to store the alarm codes. But I find it unlikely that colord has a non-functioning gamut checker, so I'm not sure what to make of that.

Expected code:

cmsSetAlarmCodesTHR(cd_icc_get_context (icc), alarm_codes);
@hughsie
Copy link
Owner

hughsie commented Jan 19, 2024

But I find it unlikely that colord has a non-functioning gamut checker

I know it used to work, but I've not used that code in anger for many years.

cmsSetAlarmCodesTHR(cd_icc_get_context (icc), alarm_codes);

That looks much better entirely -- can you do a PR please.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants