Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for PEP-561: type-hinting [smolagents] #112

Closed
sugatoray opened this issue Jan 8, 2025 · 1 comment
Closed

Add support for PEP-561: type-hinting [smolagents] #112

sugatoray opened this issue Jan 8, 2025 · 1 comment

Comments

@sugatoray
Copy link

PEP-561 suggests how to add support for type-hinting to a python library.

Note: I have already pushed a PR for this.

@aymeric-roucher
Copy link
Collaborator

Thank you for raising this @sugatoray ! Actually we don't want to signal type checkers that the repo is correctly typed, because it is not.
Check this comment for why we don't enforce PEP-561 in other Hugging Face repositories like transformers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants