From 154839f66af1f4bb046ae68c46b76359e9cd0552 Mon Sep 17 00:00:00 2001 From: Juan Puerto <=> Date: Wed, 12 Feb 2025 15:56:17 -0500 Subject: [PATCH] chore: Simplify error check --- src/user_workspaces_server/views/workspace_view.py | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/src/user_workspaces_server/views/workspace_view.py b/src/user_workspaces_server/views/workspace_view.py index f3c6933..50ba80f 100644 --- a/src/user_workspaces_server/views/workspace_view.py +++ b/src/user_workspaces_server/views/workspace_view.py @@ -375,10 +375,9 @@ def delete(self, request, workspace_id): # If this is a workspace that has shared workspaces associated that have not been accepted, error out try: - shared_workspaces = models.SharedWorkspaceMapping.objects.filter( + if models.SharedWorkspaceMapping.objects.filter( original_workspace_id=workspace, is_accepted=False - ).all() - if shared_workspaces: + ).exists(): raise WorkspaceClientException( f"Workspace {workspace_id} has shared workspaces associated with it, that have not yet been accepted. Please cancel those shares to delete this workspace." )