Skip to content

Commit cb1a2e0

Browse files
committed
Drop support for Node before v20
We continue testing in Node v18 which _should_ work for a while, but not guarantees - only Node v20+ is now officially supported as v18 is now end-of-life anyway.
1 parent 6c8ce9b commit cb1a2e0

File tree

3 files changed

+6
-7
lines changed

3 files changed

+6
-7
lines changed

.github/workflows/ci.yml

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ jobs:
77

88
strategy:
99
matrix:
10-
node-version: [16.x, 18.x, 20.x, 22.x, v22.14.0, 23.x]
10+
node-version: [18.x, 20.x, 22.x, v22.14.0, 24.x]
1111

1212
steps:
1313
- uses: actions/checkout@v4
@@ -23,12 +23,11 @@ jobs:
2323

2424
- run: npm run ci-tests
2525
env:
26-
# The new type stripping breaks our existing ts-node testing
27-
# set up, so disable it:
28-
NODE_OPTIONS: ${{ startsWith(matrix.node-version, '23') && '--no-experimental-strip-types' || '' }}
26+
# The new type stripping breaks our existing ts-node testing set up, so disable it for Node 22+
27+
NODE_OPTIONS: ${{ !startsWith(matrix.node-version, '20') && '--no-experimental-strip-types' || '' }}
2928

3029
- name: Deploy docs
31-
if: github.ref == 'refs/heads/main' && matrix.node-version == 'v20.18.1'
30+
if: github.ref == 'refs/heads/main' && matrix.node-version == 'v22.14.0'
3231
uses: JamesIves/github-pages-deploy-action@v4
3332
with:
3433
single-commit: true

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -156,7 +156,7 @@
156156
"zstd-codec": "^0.1.4"
157157
},
158158
"engines": {
159-
"node": ">=14.14.0"
159+
"node": ">=20.0.0"
160160
},
161161
"dependencies": {
162162
"@graphql-tools/schema": "^8.5.0",

test/test-utils.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -303,7 +303,7 @@ export const nodeSatisfies = (range: string) =>
303303

304304
export const DETAILED_TLS_ERROR_CODES = ">=18";
305305
export const NATIVE_FETCH_SUPPORTED = ">=18";
306-
export const SOCKET_RESET_SUPPORTED = "^16.17 || >=18.3";
306+
export const SOCKET_RESET_SUPPORTED = ">=18.3";
307307
export const BROKEN_H1_OVER_H2_TUNNELLING = "^18.8";
308308
export const DEFAULT_KEEP_ALIVE = ">=19";
309309
export const FIXED_KEEP_ALIVE_BEHAVIOUR = ">=20";

0 commit comments

Comments
 (0)