Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make Response::new return Result<Self> #327

Open
yoshuawuyts opened this issue Jan 24, 2021 · 1 comment
Open

make Response::new return Result<Self> #327

yoshuawuyts opened this issue Jan 24, 2021 · 1 comment
Labels
semver-major This change requires a semver major change
Milestone
3.0

Comments

@yoshuawuyts
Copy link
Member

So Response::new(9000) no longer panics but returns an error instead. This will match the new Request constructor as well.

This was brought up on Reddit in response to the v2.10.0 announcement and is actually something we should do.
@yoshuawuyts yoshuawuyts added the semver-major This change requires a semver major change label Jan 24, 2021
@Fishrock123
Copy link
Member

I'd also prefer this change.

@Fishrock123 Fishrock123 added this to the 3.0 milestone Jan 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
semver-major This change requires a semver major change
Projects
None yet
Milestone
3.0
Development

No branches or pull requests
2 participants
@Fishrock123 @yoshuawuyts