Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Numeric option items should have increment & decrement controls #737

Closed
Explorer09 opened this issue Aug 13, 2021 · 12 comments · May be fixed by #745
Closed

Numeric option items should have increment & decrement controls #737

Explorer09 opened this issue Aug 13, 2021 · 12 comments · May be fixed by #745
Labels
enhancement Extension or improvement to existing feature good first issue 🥇 Good for newcomers needs-discussion 🤔 Changes need to be discussed and require consent
Milestone

Comments

@Explorer09
Copy link
Contributor

Explorer09 commented Aug 13, 2021

A usability problem I recently discovered.

htop-display-numeric-options

In "Setup"->"Display options", several items take numeric values instead of boolean/checkbox. However, there're no obvious hints on how to adjust the value. The users have to guess which keys would adjust the values.

Suggestion: The function bar should include at least "increment" and "decrement" buttons for the numeric option item. This (1) shows the user which keys to press in order to adjust the values, and (2) it allows mouse users to adjust the values too.

I might also suggest a "revert" button in the function bar, but that would be a separate discussion.

@BenBE BenBE added enhancement Extension or improvement to existing feature good first issue 🥇 Good for newcomers needs-discussion 🤔 Changes need to be discussed and require consent labels Aug 13, 2021
@BenBE BenBE added this to the 3.1.1 milestone Aug 13, 2021
@ahmedaabouzied
Copy link

Hi @Explorer09 , @BenBE,

I'd like to work on this little task. It's the first time I'll be working with the htop source code. I think this is a good place for me to start.

As @Explorer09 suggested, we can add | + | Increment | - | Decrement | buttons added to the function bar that only show up when the user is on a numeric value in the display options.

I see that the keys +, - increment and decrement the numeric values. But the Enter key increments the values as well. I found that the Enter key increments the values confusing. Should we keep it that way?

@BenBE
Copy link
Member

BenBE commented Aug 15, 2021

Hi @ahmedaabouzied,

that's correct: The + and - keys increment and decrement the value respectively. The Enter key is intentional, as setting all the other (non-numeric) options reacts to Enter just the same.

If you have any questions or need some help with the implementation feel free to ask.

@BenBE BenBE modified the milestones: 3.2.0, 3.1.2 Oct 17, 2021
@BenBE BenBE modified the milestones: 3.1.2, 3.2.0 Nov 28, 2021
@fasterit fasterit modified the milestones: 3.2.0, 3.3.0 Feb 24, 2022
@BenBE BenBE modified the milestones: 3.3.0, 3.4.0 Dec 26, 2023
@rustedusted
Copy link

hey there can i work on this i saw that there is no active discussion for this for last few years so just thought if i could take up the issue

also if it's fine with you guys can you put a hacktoberfest label on this as i'm participating :D

@rustedusted
Copy link

i also have a suggestion can we even have f1 f2 to increament and decreament values when hovering on that option so that people can read on bar below how to modify values

just asking or is there a better way

@fasterit
Copy link
Member

F7 and F8 would make more sense as that is Nice - and Nice + on the main panel

@rustedusted
Copy link

oh yeah makes sense :D will do that then

@rustedusted
Copy link

hey there quick update there are only 6 spaces for writing things on the bottom row

increament being 10 characters long cannot be fitted into a space of 6 what do i do

i feel like increasing the space from 6 to 10 wouldn't be a good option

Raise - Lower
Plus - Minus
Gain - Lose

these are few options one of which can be displayed for f7 f8

these are all less then 6 characters and convey the message of increament and decreament

@rustedusted
Copy link

also toggle is 6 character long which might look slightly ugly as it will leave no space on right side should i use "flip" instead?

@BenBE
Copy link
Member

BenBE commented Oct 16, 2024

Inc and Dec are also quite short … Or Value+/Value-

@rustedusted
Copy link

oh okay i think value+ value- will be more intuitive and also i had to ask if there should be key for toggle controls?? i mean something that will be used for checkboxes?

rustedusted added a commit to rustedusted/htop that referenced this issue Oct 16, 2024
…8 keybindings to increaement decreament in setup panel

This is about issue htop-dev#737
@BenBE
Copy link
Member

BenBE commented Oct 16, 2024

Checkboxes already have several keys they react to. No need for yet another option there …

Also, this issue was less about additional keys, but about visually presenting these options in the settings screen around that control.

@rustedusted
Copy link

oh you're right it was about visually presenting these options
and there are many keys already present

i've added 2 keys should i remove them then??

if there's any suggestions please let me know i'll commit those right away

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Extension or improvement to existing feature good first issue 🥇 Good for newcomers needs-discussion 🤔 Changes need to be discussed and require consent
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants