Skip to content

Release builds broken with Rust 1.23.0-beta.1 #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
rillian opened this issue Nov 28, 2017 · 3 comments
Closed

Release builds broken with Rust 1.23.0-beta.1 #26

rillian opened this issue Nov 28, 2017 · 3 comments

Comments

@rillian
Copy link

rillian commented Nov 28, 2017

Builds with the current rust beta fail tests:

$ rustup update beta
$ cargo +beta test --release
[...]
failures:

---- test_labels_names::test_all_labels stdout ----
	thread 'test_labels_names::test_all_labels' panicked at 'assertion failed: `(left == right)`
  left: `Some(Encoding { windows-1252 })`,
 right: `Some(Encoding { windows-1252 })`', src/test_labels_names.rs:11:4
note: Run with `RUST_BACKTRACE=1` for a backtrace.

---- tests::test_label_resolution stdout ----
	thread 'tests::test_label_resolution' panicked at 'assertion failed: `(left == right)`
  left: `Some(Encoding { UTF-8 })`,
 right: `Some(Encoding { UTF-8 })`', src/lib.rs:4419:8


failures:
    test_labels_names::test_all_labels
    tests::test_label_resolution

test result: FAILED. 106 passed; 2 failed; 0 ignored; 0 measured; 0 filtered out

error: test failed, to rerun pass '--lib'
@rillian
Copy link
Author

rillian commented Nov 28, 2017

See also Firefox bug 1421100.

@hsivonen
Copy link
Owner

Looks like a Rust bug.

@hsivonen
Copy link
Owner

hsivonen commented Jan 3, 2018

Fixed in rustc.

@hsivonen hsivonen closed this as completed Jan 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants