Skip to content

Commit 06de4b6

Browse files
committed
map_merge: fix bug. estimation_confidence had no effect
* setting estimation_confidence param had no effect on merging
1 parent d59acfa commit 06de4b6

File tree

2 files changed

+5
-3
lines changed

2 files changed

+5
-3
lines changed

map_merge/include/map_merge/map_merge.h

+1-1
Original file line numberDiff line numberDiff line change
@@ -74,7 +74,7 @@ class MapMerge
7474
double merging_rate_;
7575
double discovery_rate_;
7676
double estimation_rate_;
77-
double confidence_treshold_;
77+
double confidence_threshold_;
7878
std::string robot_map_topic_;
7979
std::string robot_map_updates_topic_;
8080
std::string robot_namespace_;

map_merge/src/map_merge.cpp

+4-2
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,7 @@ MapMerge::MapMerge() : subscriptions_size_(0)
5454
private_nh.param("discovery_rate", discovery_rate_, 0.05);
5555
private_nh.param("estimation_rate", estimation_rate_, 0.5);
5656
private_nh.param("known_init_poses", have_initial_poses_, true);
57-
private_nh.param("estimation_confidence", confidence_treshold_, 1.0);
57+
private_nh.param("estimation_confidence", confidence_threshold_, 1.0);
5858
private_nh.param<std::string>("robot_map_topic", robot_map_topic_, "map");
5959
private_nh.param<std::string>("robot_map_updates_topic",
6060
robot_map_updates_topic_, "map_updates");
@@ -199,7 +199,9 @@ void MapMerge::poseEstimation()
199199

200200
std::lock_guard<std::mutex> lock(pipeline_mutex_);
201201
pipeline_.feed(grids.begin(), grids.end());
202-
pipeline_.estimateTransforms();
202+
// TODO allow user to change feature type
203+
pipeline_.estimateTransforms(combine_grids::FeatureType::AKAZE,
204+
confidence_threshold_);
203205
}
204206

205207
void MapMerge::fullMapUpdate(const nav_msgs::OccupancyGrid::ConstPtr& msg,

0 commit comments

Comments
 (0)