From e17f6c758293bb207d1a3f4e9ed5fe74dd83ae89 Mon Sep 17 00:00:00 2001 From: Emilien Escalle Date: Wed, 1 Jul 2026 18:01:30 +0200 Subject: [PATCH] feat: add timeout inputs for deployment checks and get-finished action Signed-off-by: Emilien Escalle --- .github/workflows/deploy-checks.yml | 8 ++++++++ .github/workflows/deploy-finish.yml | 16 ++++++++++++++++ actions/deployment/get-finished/action.yml | 2 +- 3 files changed, 25 insertions(+), 1 deletion(-) diff --git a/.github/workflows/deploy-checks.yml b/.github/workflows/deploy-checks.yml index 3533abf6..6140cc5b 100644 --- a/.github/workflows/deploy-checks.yml +++ b/.github/workflows/deploy-checks.yml @@ -30,6 +30,13 @@ on: type: string required: false default: "./budget.json" + ping-timeout: + description: | + Timeout in seconds for the URL ping check. + See [`url-ping`](../../actions/check/url-ping/README.md). + type: string + required: false + default: "60" print-summary: description: "Whether to print a summary of the checks." type: boolean @@ -79,6 +86,7 @@ jobs: id: ping with: url: ${{ inputs.url }} + timeout: ${{ inputs['ping-timeout'] }} - id: lighthouse uses: ./../self-workflow/actions/check/url-lighthouse diff --git a/.github/workflows/deploy-finish.yml b/.github/workflows/deploy-finish.yml index 86793f5d..b6805d13 100644 --- a/.github/workflows/deploy-finish.yml +++ b/.github/workflows/deploy-finish.yml @@ -35,6 +35,20 @@ on: type: string required: false default: "./budget.json" + deployment-timeout: + description: | + Maximum time to wait for the deployment to reach a terminal state, in seconds. + See [`get-finished`](../../actions/deployment/get-finished/README.md). + type: string + required: false + default: "300" + ping-timeout: + description: | + Timeout in seconds for the URL ping check. + See [`url-ping`](../../actions/check/url-ping/README.md). + type: string + required: false + default: "60" extra: description: | Extra information to send to the deployment summary. @@ -71,6 +85,7 @@ jobs: uses: ./../self-workflow/actions/deployment/get-finished with: deployment-id: ${{ inputs.deployment-id }} + timeout: ${{ inputs.deployment-timeout }} deploy-checks: name: Deploy checks @@ -83,6 +98,7 @@ jobs: runs-on: ${{ inputs.runs-on }} url: ${{ needs.get-finished-deployment.outputs.url }} budget-path: ${{ inputs.budget-path }} + ping-timeout: ${{ inputs.ping-timeout }} print-summary: false deploy-result: diff --git a/actions/deployment/get-finished/action.yml b/actions/deployment/get-finished/action.yml index 5553ef68..83a83830 100644 --- a/actions/deployment/get-finished/action.yml +++ b/actions/deployment/get-finished/action.yml @@ -20,7 +20,7 @@ inputs: timeout: description: "Maximum time to wait for a terminal deployment status, in seconds" required: false - default: "240" + default: "300" allow-failure: description: | If "true", the action will not mark the step as failed when the deployment finishes with a non-success terminal state