Skip to content

Commit cbae039

Browse files
committed
fix(scripts/commit-msg): actually forward arguments to commitlint 😞
- Fixes use case of actually passing `--edit $1` for example - Also fixes passing a custom config via `--config`
1 parent 22f5713 commit cbae039

File tree

3 files changed

+4
-4
lines changed

3 files changed

+4
-4
lines changed

src/scripts/__tests__/__snapshots__/commit-msg.js.snap

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,8 @@ exports[`commit-msg adds env flag with HUSKY_GIT_PARAMS when available 1`] = `co
44

55
exports[`commit-msg calls @commitlint/cli with default args 1`] = `commitlint --config ./src/config/commitlint.config.js`;
66

7-
exports[`commit-msg does not use built-in config with --config 1`] = `commitlint`;
7+
exports[`commit-msg does not use built-in config with --config 1`] = `commitlint --config ./custom-config.js`;
88

99
exports[`commit-msg does not use built-in config with commitlint.config.js file 1`] = `commitlint`;
1010

11-
exports[`commit-msg forwards args 1`] = `commitlint --config ./src/config/commitlint.config.js`;
11+
exports[`commit-msg forwards args 1`] = `commitlint --config ./src/config/commitlint.config.js --edit .git/COMMIT_EDITMSG`;

src/scripts/__tests__/commit-msg.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,7 @@ cases(
5757
hasFile: filename => filename === 'commitlint.config.js',
5858
},
5959
'forwards args': {
60-
args: ['--verbose'],
60+
args: ['--edit', '.git/COMMIT_EDITMSG'],
6161
},
6262
'adds env flag with HUSKY_GIT_PARAMS when available': {
6363
env: {HUSKY_GIT_PARAMS: 'husky-git-params'},

src/scripts/commit-msg.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ const config = useBuiltinConfig
2121

2222
const result = spawn.sync(
2323
resolveBin('@commitlint/cli', {executable: 'commitlint'}),
24-
[...env, ...config],
24+
[...env, ...config, ...args],
2525
{
2626
stdio: 'inherit',
2727
},

0 commit comments

Comments
 (0)