-
Notifications
You must be signed in to change notification settings - Fork 10
Depend on nuget packages instead of submodule #64
Open
martijnhoekstra
wants to merge
2
commits into
hotsapi:master
Choose a base branch
from
martijnhoekstra:depend
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Submodule Heroes.ReplayParser
deleted from
abf87d
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,71 +1,51 @@ | ||
| | ||
| Microsoft Visual Studio Solution File, Format Version 12.00 | ||
| # Visual Studio Version 16 | ||
| VisualStudioVersion = 16.0.29519.87 | ||
| MinimumVisualStudioVersion = 10.0.40219.1 | ||
| Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "Hotsapi.Uploader.Common", "Hotsapi.Uploader.Common\Hotsapi.Uploader.Common.csproj", "{DC695BCC-4403-4B20-B4F5-EB80683E5967}" | ||
| EndProject | ||
| Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "Hotsapi.Uploader.Windows", "Hotsapi.Uploader.Windows\Hotsapi.Uploader.Windows.csproj", "{F774F86B-410F-410D-9719-ADF892D315D5}" | ||
| EndProject | ||
| Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "MpqTool.netstandard", "Heroes.ReplayParser\MpqTool\MpqTool.netstandard.csproj", "{401F4637-5826-4DDA-A666-A3B4D1994330}" | ||
| EndProject | ||
| Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "Heroes.ReplayParser.netstandard", "Heroes.ReplayParser\Heroes.ReplayParser\Heroes.ReplayParser.netstandard.csproj", "{7CEC9C7E-3DC6-4C72-8DFF-FE07D086B3A4}" | ||
| EndProject | ||
| Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "Hotsapi.Uploader.Common.Test", "Hotsapi.Uploader.Common.Test\Hotsapi.Uploader.Common.Test.csproj", "{F0AF2897-857E-462E-86E0-2812624E2F78}" | ||
| EndProject | ||
| Global | ||
| GlobalSection(SolutionConfigurationPlatforms) = preSolution | ||
| Debug|Any CPU = Debug|Any CPU | ||
| Installer|Any CPU = Installer|Any CPU | ||
| Release|Any CPU = Release|Any CPU | ||
| Zip|Any CPU = Zip|Any CPU | ||
| EndGlobalSection | ||
| GlobalSection(ProjectConfigurationPlatforms) = postSolution | ||
| {DC695BCC-4403-4B20-B4F5-EB80683E5967}.Debug|Any CPU.ActiveCfg = Debug|Any CPU | ||
| {DC695BCC-4403-4B20-B4F5-EB80683E5967}.Debug|Any CPU.Build.0 = Debug|Any CPU | ||
| {DC695BCC-4403-4B20-B4F5-EB80683E5967}.Installer|Any CPU.ActiveCfg = Release|Any CPU | ||
| {DC695BCC-4403-4B20-B4F5-EB80683E5967}.Installer|Any CPU.Build.0 = Release|Any CPU | ||
| {DC695BCC-4403-4B20-B4F5-EB80683E5967}.Release|Any CPU.ActiveCfg = Release|Any CPU | ||
| {DC695BCC-4403-4B20-B4F5-EB80683E5967}.Release|Any CPU.Build.0 = Release|Any CPU | ||
| {DC695BCC-4403-4B20-B4F5-EB80683E5967}.Zip|Any CPU.ActiveCfg = Release|Any CPU | ||
| {DC695BCC-4403-4B20-B4F5-EB80683E5967}.Zip|Any CPU.Build.0 = Release|Any CPU | ||
| {F774F86B-410F-410D-9719-ADF892D315D5}.Debug|Any CPU.ActiveCfg = Debug|Any CPU | ||
| {F774F86B-410F-410D-9719-ADF892D315D5}.Debug|Any CPU.Build.0 = Debug|Any CPU | ||
| {F774F86B-410F-410D-9719-ADF892D315D5}.Installer|Any CPU.ActiveCfg = Installer|Any CPU | ||
| {F774F86B-410F-410D-9719-ADF892D315D5}.Installer|Any CPU.Build.0 = Installer|Any CPU | ||
| {F774F86B-410F-410D-9719-ADF892D315D5}.Release|Any CPU.ActiveCfg = Release|Any CPU | ||
| {F774F86B-410F-410D-9719-ADF892D315D5}.Release|Any CPU.Build.0 = Release|Any CPU | ||
| {F774F86B-410F-410D-9719-ADF892D315D5}.Zip|Any CPU.ActiveCfg = Zip|Any CPU | ||
| {F774F86B-410F-410D-9719-ADF892D315D5}.Zip|Any CPU.Build.0 = Zip|Any CPU | ||
| {401F4637-5826-4DDA-A666-A3B4D1994330}.Debug|Any CPU.ActiveCfg = Debug|Any CPU | ||
| {401F4637-5826-4DDA-A666-A3B4D1994330}.Debug|Any CPU.Build.0 = Debug|Any CPU | ||
| {401F4637-5826-4DDA-A666-A3B4D1994330}.Installer|Any CPU.ActiveCfg = Release|Any CPU | ||
| {401F4637-5826-4DDA-A666-A3B4D1994330}.Installer|Any CPU.Build.0 = Release|Any CPU | ||
| {401F4637-5826-4DDA-A666-A3B4D1994330}.Release|Any CPU.ActiveCfg = Release|Any CPU | ||
| {401F4637-5826-4DDA-A666-A3B4D1994330}.Release|Any CPU.Build.0 = Release|Any CPU | ||
| {401F4637-5826-4DDA-A666-A3B4D1994330}.Zip|Any CPU.ActiveCfg = Release|Any CPU | ||
| {401F4637-5826-4DDA-A666-A3B4D1994330}.Zip|Any CPU.Build.0 = Release|Any CPU | ||
| {7CEC9C7E-3DC6-4C72-8DFF-FE07D086B3A4}.Debug|Any CPU.ActiveCfg = Debug|Any CPU | ||
| {7CEC9C7E-3DC6-4C72-8DFF-FE07D086B3A4}.Debug|Any CPU.Build.0 = Debug|Any CPU | ||
| {7CEC9C7E-3DC6-4C72-8DFF-FE07D086B3A4}.Installer|Any CPU.ActiveCfg = Release|Any CPU | ||
| {7CEC9C7E-3DC6-4C72-8DFF-FE07D086B3A4}.Installer|Any CPU.Build.0 = Release|Any CPU | ||
| {7CEC9C7E-3DC6-4C72-8DFF-FE07D086B3A4}.Release|Any CPU.ActiveCfg = Release|Any CPU | ||
| {7CEC9C7E-3DC6-4C72-8DFF-FE07D086B3A4}.Release|Any CPU.Build.0 = Release|Any CPU | ||
| {7CEC9C7E-3DC6-4C72-8DFF-FE07D086B3A4}.Zip|Any CPU.ActiveCfg = Release|Any CPU | ||
| {7CEC9C7E-3DC6-4C72-8DFF-FE07D086B3A4}.Zip|Any CPU.Build.0 = Release|Any CPU | ||
| {F0AF2897-857E-462E-86E0-2812624E2F78}.Debug|Any CPU.ActiveCfg = Debug|Any CPU | ||
| {F0AF2897-857E-462E-86E0-2812624E2F78}.Debug|Any CPU.Build.0 = Debug|Any CPU | ||
| {F0AF2897-857E-462E-86E0-2812624E2F78}.Installer|Any CPU.ActiveCfg = Debug|Any CPU | ||
| {F0AF2897-857E-462E-86E0-2812624E2F78}.Installer|Any CPU.Build.0 = Debug|Any CPU | ||
| {F0AF2897-857E-462E-86E0-2812624E2F78}.Release|Any CPU.ActiveCfg = Release|Any CPU | ||
| {F0AF2897-857E-462E-86E0-2812624E2F78}.Release|Any CPU.Build.0 = Release|Any CPU | ||
| {F0AF2897-857E-462E-86E0-2812624E2F78}.Zip|Any CPU.ActiveCfg = Debug|Any CPU | ||
| {F0AF2897-857E-462E-86E0-2812624E2F78}.Zip|Any CPU.Build.0 = Debug|Any CPU | ||
| EndGlobalSection | ||
| GlobalSection(SolutionProperties) = preSolution | ||
| HideSolutionNode = FALSE | ||
| EndGlobalSection | ||
| GlobalSection(ExtensibilityGlobals) = postSolution | ||
| SolutionGuid = {24555457-A9E2-4C94-B0E4-1BC34F4C042B} | ||
| EndGlobalSection | ||
| EndGlobal | ||
| | ||
| Microsoft Visual Studio Solution File, Format Version 12.00 | ||
| # Visual Studio Version 16 | ||
| VisualStudioVersion = 16.0.29519.87 | ||
| MinimumVisualStudioVersion = 10.0.40219.1 | ||
| Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "Hotsapi.Uploader.Common", "Hotsapi.Uploader.Common\Hotsapi.Uploader.Common.csproj", "{DC695BCC-4403-4B20-B4F5-EB80683E5967}" | ||
| EndProject | ||
| Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "Hotsapi.Uploader.Windows", "Hotsapi.Uploader.Windows\Hotsapi.Uploader.Windows.csproj", "{F774F86B-410F-410D-9719-ADF892D315D5}" | ||
| EndProject | ||
| Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "Hotsapi.Uploader.Common.Test", "Hotsapi.Uploader.Common.Test\Hotsapi.Uploader.Common.Test.csproj", "{F0AF2897-857E-462E-86E0-2812624E2F78}" | ||
| EndProject | ||
| Global | ||
| GlobalSection(SolutionConfigurationPlatforms) = preSolution | ||
| Debug|Any CPU = Debug|Any CPU | ||
| Installer|Any CPU = Installer|Any CPU | ||
| Release|Any CPU = Release|Any CPU | ||
| Zip|Any CPU = Zip|Any CPU | ||
| EndGlobalSection | ||
| GlobalSection(ProjectConfigurationPlatforms) = postSolution | ||
| {DC695BCC-4403-4B20-B4F5-EB80683E5967}.Debug|Any CPU.ActiveCfg = Debug|Any CPU | ||
| {DC695BCC-4403-4B20-B4F5-EB80683E5967}.Debug|Any CPU.Build.0 = Debug|Any CPU | ||
| {DC695BCC-4403-4B20-B4F5-EB80683E5967}.Installer|Any CPU.ActiveCfg = Release|Any CPU | ||
| {DC695BCC-4403-4B20-B4F5-EB80683E5967}.Installer|Any CPU.Build.0 = Release|Any CPU | ||
| {DC695BCC-4403-4B20-B4F5-EB80683E5967}.Release|Any CPU.ActiveCfg = Release|Any CPU | ||
| {DC695BCC-4403-4B20-B4F5-EB80683E5967}.Release|Any CPU.Build.0 = Release|Any CPU | ||
| {DC695BCC-4403-4B20-B4F5-EB80683E5967}.Zip|Any CPU.ActiveCfg = Release|Any CPU | ||
| {DC695BCC-4403-4B20-B4F5-EB80683E5967}.Zip|Any CPU.Build.0 = Release|Any CPU | ||
| {F774F86B-410F-410D-9719-ADF892D315D5}.Debug|Any CPU.ActiveCfg = Debug|Any CPU | ||
| {F774F86B-410F-410D-9719-ADF892D315D5}.Debug|Any CPU.Build.0 = Debug|Any CPU | ||
| {F774F86B-410F-410D-9719-ADF892D315D5}.Installer|Any CPU.ActiveCfg = Installer|Any CPU | ||
| {F774F86B-410F-410D-9719-ADF892D315D5}.Installer|Any CPU.Build.0 = Installer|Any CPU | ||
| {F774F86B-410F-410D-9719-ADF892D315D5}.Release|Any CPU.ActiveCfg = Release|Any CPU | ||
| {F774F86B-410F-410D-9719-ADF892D315D5}.Release|Any CPU.Build.0 = Release|Any CPU | ||
| {F774F86B-410F-410D-9719-ADF892D315D5}.Zip|Any CPU.ActiveCfg = Zip|Any CPU | ||
| {F774F86B-410F-410D-9719-ADF892D315D5}.Zip|Any CPU.Build.0 = Zip|Any CPU | ||
| {F0AF2897-857E-462E-86E0-2812624E2F78}.Debug|Any CPU.ActiveCfg = Debug|Any CPU | ||
| {F0AF2897-857E-462E-86E0-2812624E2F78}.Debug|Any CPU.Build.0 = Debug|Any CPU | ||
| {F0AF2897-857E-462E-86E0-2812624E2F78}.Installer|Any CPU.ActiveCfg = Debug|Any CPU | ||
| {F0AF2897-857E-462E-86E0-2812624E2F78}.Installer|Any CPU.Build.0 = Debug|Any CPU | ||
| {F0AF2897-857E-462E-86E0-2812624E2F78}.Release|Any CPU.ActiveCfg = Release|Any CPU | ||
| {F0AF2897-857E-462E-86E0-2812624E2F78}.Release|Any CPU.Build.0 = Release|Any CPU | ||
| {F0AF2897-857E-462E-86E0-2812624E2F78}.Zip|Any CPU.ActiveCfg = Debug|Any CPU | ||
| {F0AF2897-857E-462E-86E0-2812624E2F78}.Zip|Any CPU.Build.0 = Debug|Any CPU | ||
| EndGlobalSection | ||
| GlobalSection(SolutionProperties) = preSolution | ||
| HideSolutionNode = FALSE | ||
| EndGlobalSection | ||
| GlobalSection(ExtensibilityGlobals) = postSolution | ||
| SolutionGuid = {24555457-A9E2-4C94-B0E4-1BC34F4C042B} | ||
| EndGlobalSection | ||
| EndGlobal |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So I switched up the parse options from feedback provided by barrret before he merged your changes. So just wanted to make sure you saw those changes. Also, why allowPTR? The uploader doesn’t upload PTR games as far as I am aware
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The again, you have to parse PTR to know it’s PTR. So probably why.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indeed, that doesn't look right. The old method signature was
ParseReplay(string fileName, bool ignoreErrors, bool deleteFile, bool allowPTRRegion = false, bool skipEventParsing = false, bool skipUnitParsing = false, bool skipMouseMoveEvents = false, bool detailedBattleLobbyParsing = false)so that'signoreErrors = false,deleteFile = false,allowPTR = false,skipEventParseing = true,skipUnitParsing=false,skipMouseMoveEvents = falseanddetailedBattleLobbyParsing = false. But that's odd: why not skip mouse events. Closing this to look again.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you maybe help me out with the versioning? I'm completely lost on where to find which commit is published in which version of the package.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The owner of the repo requested the defaulted state be the same as the previous default state for consistently and reduce confusion. Which makes sense to me
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I opened barrett777/Heroes.ReplayParser#97
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have the impression that the build error is related to GitVersion. I asked around at https://gitter.im/GitTools/GitVersion?at=5e29c4d2f85dba0aab003034
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@martijnhoekstra GitVersion is a development-only dependency. It shouldn't be included in or affect the NuGet package: https://github.com/barrett777/Heroes.ReplayParser/blob/master/Heroes.ReplayParser/Heroes.ReplayParser.csproj#L15-L16
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did have issues in development with replays all returning Exception, and I think the issue was different versions of 'sharpcompress'. Do any other projects in this solution use it? I think you need to make sure they are all 0.24.0 or later
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A version mismatch of sharpcompress was indeed the issue. It's troublesome that exceptions are swallowed like this to debug this.