fix mocks to set success status

Author: Martijn Hoekstra

Hotsapi.Uploader.Common.Test/ManagerTests.cs

@@ -8,7 +8,7 @@ namespace Hotsapi.Uploader.Common.Test
     [TestClass]
     public partial class ManagerTests
     {
-        private Task ShortRandomDelay()
+        public static Task ShortRandomDelay()
         {
             var r = new Random();
             var delay = r.Next(100, 200);
@@ -132,8 +132,9 @@ public async Task AllInitialFilesProcessed()
             });
 
             manager.Start(new NoNewFilesMonitor(), new MockAnalizer(), uploadTester);
-            var finished = await Task.WhenAny(Task.Delay(4000), done.Task);
-            await finished;
+            var num = await done.Task;
+            //var finished = await Task.WhenAny(Task.Delay(4000), done.Task);
+            //await finished;
             Assert.AreEqual(3, uploadsSeen);
         }
     }

Hotsapi.Uploader.Common.Test/MockAnalizer.cs

@@ -7,7 +7,10 @@ public partial class ManagerTests
         private class MockAnalizer : IAnalyzer
         {
             public int MinimumBuild { get; set; }
-            public Replay Analyze(ReplayFile file) => new Replay();
+            public Replay Analyze(ReplayFile file) {
+                file.UploadStatus = UploadStatus.Preprocessed;
+                return new Replay();
+            }
             public string GetFingerprint(Replay replay) => "dummy fingerprint";
         }
     }

Hotsapi.Uploader.Common.Test/MockUploader.cs

@@ -21,7 +21,13 @@ public void SetUploadCallback(Func<ReplayFile, Task> onUpload)
                 };
             }
 
-            public Task CheckDuplicate(IEnumerable<ReplayFile> replays) => Task.CompletedTask;
+            public async Task CheckDuplicate(IEnumerable<ReplayFile> replays)
+            {
+                foreach (var replay in replays) {
+                    replay.UploadStatus = UploadStatus.ReadyForUpload;
+                }
+                await ShortRandomDelay(); //todo: put this elsewhere
+            }
             public Task<int> GetMinimumBuild() => Task.FromResult(1);
             public Task Upload(ReplayFile file)
             {

Hotsapi.Uploader.Common/Manager.cs

@@ -106,7 +106,9 @@ public async void Start(IMonitor monitor, IAnalyzer analyzer, IUploader uploader
 
             var replays = ScanReplays();
             Files.AddRange(replays);
-            replays.Where(x => x.UploadStatus == UploadStatus.None).Reverse().Map(x => processingQueue.Add(x));
+            replays.Where(x => x.UploadStatus == UploadStatus.None)
+                   .Reverse()
+                   .Map(processingQueue.Add);
 
             _monitor.ReplayAdded += async (_, e) => {
                 await EnsureFileAvailable(e.Data, 3000);