Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider adding entrypoint to check for database connection prior to running #4

Open
spwoodcock opened this issue Jan 30, 2025 · 0 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@spwoodcock
Copy link
Member

Is your feature request related to a problem? Please describe.

  • Typically this service would run with a depends_on and and healthcheck for a database, waiting until the db is healthy before running.
  • When extending the official ODK Central stack, the database does not have a healthcheck.
  • We encounter an error connecting while it initialises, before showing the successful connection on retry:

Image

Describe the solution you'd like

  • Assess possibility of lightweight healthcheck for database, prior to running this service.

Describe alternatives you've considered

  • The postgres14 service in the official stack could simply be extended to add a healthcheck.

Additional context

  • This might require adding a shell, which I'm not that keen on.
  • Currently the image is built on scratch, meaning no sh or bash present, for optimal security.
@spwoodcock spwoodcock added the enhancement New feature or request label Jan 30, 2025
@spwoodcock spwoodcock added the help wanted Extra attention is needed label Feb 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant