Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.26%. Comparing base (031a4f4) to head (3b4bf9e).

@@           Coverage Diff           @@
##             main    #1017   +/-   ##
=======================================
  Coverage   87.25%   87.26%           
=======================================
  Files           9        9           
  Lines        4928     4930    +2     
=======================================
+ Hits         4300     4302    +2     
  Misses        628      628           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Glad to see this one caught! I think that was my oversight orginally. Sorry about that!

Any dependency between Parameter attributes (looking at you Selector) makes attribute inheritance more complex. In this case, one could argue there isn't really a need to automatically set constant=True when readonly=True!

Any dependency between Parameter attributes (looking at you Selector) makes attribute inheritance more complex.

That's true.

In this case, one could argue there isn't really a need to automatically set constant=True when readonly=True!

But then we'd have to wonder what it means for constant=False and readonly=True, which seems like a bizarre case to even consider. Maybe it would have been best to handle that on attribute access, not via defaults?

But then we'd have to wonder what it means for constant=False and readonly=True

I think I could live with that as readonly takes precedence over constant in my mind. Though it's easy for me as I've internalized what readonly and constant mean but for most users, their effect isn't obvious, readonly meaning can_never_be_updated and constant meaning cannot_be_updated_after_instantiation.

Maybe it would have been best to handle that on attribute access, not via defaults?

I don't know and don't want to think about it too much :D

EDIT:

Coming back to the first point, readonly takes precedence over constant not only in my mind but in Param too. parameter = Parameter(readonly=True, constant=False) doesn't raise any error or emit any warning, it internally sets constant to True.