Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce async/await #20

Open
holly-hacker opened this issue Jul 18, 2019 · 2 comments
Open

Introduce async/await #20

holly-hacker opened this issue Jul 18, 2019 · 2 comments
Labels
code quality Improvement to the readability or robustness of code enhancement New feature or request

Comments

@holly-hacker
Copy link
Owner

holly-hacker commented Jul 18, 2019 •
edited
Loading

Most code runs on the UI thread and is thus blocking. That includes DLL Injection, which is bad because it can take a while.

This also prevents embarrassing issues such as 0xd4d/dnSpy#1212.
@holly-hacker holly-hacker added enhancement New feature or request code quality Improvement to the readability or robustness of code labels Jul 18, 2019
@holly-hacker holly-hacker added this to the v0.4.0 milestone Jul 18, 2019
@holly-hacker holly-hacker self-assigned this Jul 18, 2019
@holly-hacker
Copy link
Owner Author

Planning on implementing this on the unity-dll-injection branch.

@holly-hacker holly-hacker mentioned this issue Jul 22, 2019
Merged
@holly-hacker
Copy link
Owner Author

Not needed yet and pretty invasive, I'll do this later when we're actually trying to perform work on the UI thread.

@holly-hacker holly-hacker removed this from the v0.4.0 milestone Jul 22, 2019
@holly-hacker holly-hacker removed their assignment Jul 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
code quality Improvement to the readability or robustness of code enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@holly-hacker