Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QUESTION/BUG/ENHANCEMENT: How does AUTO_LEAVE work #59

Open
TheJoshue opened this issue Dec 8, 2024 · 1 comment
Open

QUESTION/BUG/ENHANCEMENT: How does AUTO_LEAVE work #59

TheJoshue opened this issue Dec 8, 2024 · 1 comment
Labels
question Further information is requested

Comments

@TheJoshue
Copy link

I see that we can use /leave command aswell as that stop button (image):
image

I see that when AUTO_LEAVE is set to true, when you use /leave command or press this button, the bot will stop playing and will leave immediately

On the other side when AUTO_LEAVE is set to false, the bot will not leave even when you MANUALLY execute /leave -> this is not what AUTO_LEAVE should prevent! auto leave indicated "automatically leave", and using /leave command or pressing the button is not automatic - it is done manually by the user (who is in the channel of course and is only allowed for them to use bot commands/interactions)

So i wanted to address that AUTO_LEAVE if set to true, should ONLY do next:

  • leave voice channel after it is done with playing a track
    • if stop interaction button is pressed, it will STOP the music, that is not the same as leave command! it will break playing track and because auto leave is set to true it will leave only because it is set to true
  • leave voice channel if number of users inside of that channel (joined that channel, currently) is 0 (so if last user leaves the channel and the bot is left alone, he will leave too)
    • leave voice channel even if playing music but the count of currently joined users is 0 (when last user leaves, bot leaves too)

In other case (if AUTO_LEAVE is false):

  • do not leave voice channel after it is done with playing track
    • if stop interaction button is pressed, it will STOP the music and not leave until someone used /leave command or someone disconnected him from the channel or it times out from the channel (this will be next suggestion)
  • do not leave voice channel if number of users in the channel goes to 0
    • implement new env variable for controlling if it should stop playing music when all users leave the channel or not called for example AUTO_LEAVE_FALSE_STOP_PLAYING_ALONE which if set to true, it will stop playing fully (or pause? and resume when someone joins back) and if set to false, it will not stop playing music
@TheJoshue TheJoshue added the question Further information is requested label Dec 8, 2024
@TheJoshue
Copy link
Author

I actually think that most of this work fine right now, and the button actually works fine it just does not indicate anywhere if it means "stop" or "leave" because when pressed it outputs "Bot leave" message and leaves
I only think that when AUTO LEAVE is false, it should not send "Bot leave" message when you press stop button because the bot did not left the channel (it's not leaving it because auto leave is false) so something here is over-working.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

1 participant