Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question: does this use numpy histograms? #32

Closed
dguest opened this issue Aug 14, 2018 · 1 comment
Closed

Question: does this use numpy histograms? #32

dguest opened this issue Aug 14, 2018 · 1 comment

Comments

@dguest
Copy link

dguest commented Aug 14, 2018

I was looking to use this to get around a simple issue that I have with numpy histograms: specifically, numpy histograms work by calculating a cumulative sum across the bin ranges, which means that when weights vary by a factor of 10e6 or so from one end of the spectrum to the other (i.e. in simulated LHC dijet spectra) the low-weight end is lost to roundoff error.

I took a look and it wasn't clear if numpy histograms are being used behind the scenes. If not, great, this is probably exactly what I need. If so, also great, because as part of this project we should probably fix numpy histograms.

@jpivarski
Copy link
Member

This does not use Numpy histograms.

However, I'm in the process of deprecating Histogrammar in favor of histbook, which also doesn't use Numpy histograms. histbook uses Numpy arrays to store and manipulate aggregated data, but the actual bin updates are performed with numpy.add.at, nothing cumulative.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants