Skip to content
This repository has been archived by the owner on May 29, 2018. It is now read-only.

GitHub camo caches the redirection #1

Closed
hiendv opened this issue Aug 19, 2016 · 5 comments
Closed

GitHub camo caches the redirection #1

hiendv opened this issue Aug 19, 2016 · 5 comments
Assignees
Labels
Milestone

Comments

@hiendv
Copy link
Owner

hiendv commented Aug 19, 2016

github/markup#224 (comment)
github/markup#224 (comment)

@hiendv hiendv added the bug label Aug 19, 2016
@hiendv hiendv added this to the v0.1.1 milestone Aug 19, 2016
@hiendv hiendv self-assigned this Aug 19, 2016
@hiendv hiendv closed this as completed in 829d759 Aug 19, 2016
@hiendv
Copy link
Owner Author

hiendv commented Aug 19, 2016

Well, it didn't go away.
atmos/camo#85
lemurheavy/coveralls-public#414
So instead of revalidating the original 302 request, they revalidate the final URL.

@hiendv hiendv reopened this Aug 19, 2016
@hiendv hiendv closed this as completed in 761dd6a Aug 19, 2016
@hiendv
Copy link
Owner Author

hiendv commented Aug 19, 2016

I didn't, again. I thought it's because of Cloudflare but it is not.

curl -I "https://hireable.0x1115.org/hiendv"

HTTP/1.1 301 Moved Permanently
ETag: "bcabf2d2f9492a6e38d7425f919b1ba8"
Cache-Control: no-cache, no-store, must-revalidate
Location: /hireable-error.svg
Content-Type: text/html; charset=utf-8
Content-Length: 69
Date: Fri, 19 Aug 2016 10:12:06 GMT
Connection: keep-alive

What about the final URL?

curl -I "https://hireable.0x1115.org/hireable-error.svg"

HTTP/1.1 200 OK
Last-Modified: Wed, 17 Aug 2016 19:33:06 GMT
Content-Length: 741
Cache-Control: max-age=0
Content-Type: image/svg+xml
Date: Fri, 19 Aug 2016 10:14:28 GMT
Connection: keep-alive

Let see whether atmos has an answer or not.

@hiendv
Copy link
Owner Author

hiendv commented Aug 19, 2016

@hiendv
Copy link
Owner Author

hiendv commented Aug 19, 2016

Investigating.
Dispite the fact that GET parameters don't affect the result at all. I changed my job profile between each time of previewing

[![](https://hireable.0x1115.org/hiendv?foo=bar)](https://hireable.0x1115.org/p/hiendv)
[![](https://hireable.0x1115.org/hiendv?fooo=bar)](https://hireable.0x1115.org/p/hiendv)

@hiendv
Copy link
Owner Author

hiendv commented Aug 19, 2016

Updated.

curl -I "https://hireable.0x1115.org/hireable-error.svg"

HTTP/1.1 200 OK
Cache-Control: no-cache
Content-Length: 741
Content-Type: image/svg+xml
Date: Fri, 19 Aug 2016 11:44:51 GMT
Last-Modified: Wed, 17 Aug 2016 19:33:06 GMT
Server: Caddy

@hiendv hiendv closed this as completed in 9926d7d Aug 19, 2016
hiendv added a commit that referenced this issue Aug 19, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

1 participant