Update hh-apidoc to v0.8

v0.8 got more picky about various pre-existing bugs

refs #1125

Author: fredemmott

composer.lock

@@ -17,6 +17,7 @@
   ScannedDefinition,
   ScannedFunction,
   ScannedFunctionish,
+  ScannedMethod,
   ScannedNewtype,
   ScannedType,
 };
@@ -72,7 +73,6 @@ public static function isHHSpecific(ScannedDefinition $def): bool {
     ) {
       return true;
     }
-
     return false;
   }
 
@@ -87,8 +87,10 @@ private static function getPHPList(string $type): keyset<string> {
 
   public static function shouldNotDocument(ScannedDefinition $def): bool {
     return (
-      Str\starts_with($def->getName(), '_') // non-namespaced name starts with _
-      ||
+      (
+        // non-namespaced name starts with _
+        Str\starts_with($def->getName(), '_') && !($def is ScannedMethod)
+      ) ||
       Str\contains($def->getName(), '\\_') // namespaced name starts with _
       ||
       Str\contains($def->getName(), 'WaitHandle') ||

src/api-gen/ScannedDefinitionFilters.php

@@ -379,9 +379,9 @@ private static function buildMarkdown(
         // Empty index; this is used for auto-linking, but we do that when
         // processing the markdown, instead of when generating it.
         shape(
-          'types' => keyset[],
-          'newtypes' => keyset[],
-          'functions' => keyset[],
+          'types' => dict[],
+          'newtypes' => dict[],
+          'functions' => dict[],
           'classes' => dict[],
           'interfaces' => dict[],
           'traits' => dict[],
@@ -391,6 +391,7 @@ private static function buildMarkdown(
           'format' => HHAPIDoc\OutputFormat::MARKDOWN,
           'syntaxHighlighting' => true,
           'hidePrivateMethods' => true,
+          'hideInheritedMethods' => false,
         ),
       )
     );

src/build/HHAPIDocBuildStep.php

@@ -26,18 +26,21 @@ public function __construct() {
   public function getPathForClass(string $class): ?string {
     return $this->providers
       |> Vec\map($$, $p ==> $p->getPathForClass($class))
+      |> Vec\filter_nulls($$)
       |> C\first($$);
   }
 
   public function getPathForInterface(string $class): ?string {
     return $this->providers
       |> Vec\map($$, $p ==> $p->getPathForInterface($class))
+      |> Vec\filter_nulls($$)
       |> C\first($$);
   }
 
   public function getPathForTrait(string $class): ?string {
     return $this->providers
       |> Vec\map($$, $p ==> $p->getPathForTrait($class))
+      |> Vec\filter_nulls($$)
       |> C\first($$);
   }
 
@@ -47,6 +50,7 @@ public function getPathForClassMethod(
   ): ?string {
     return $this->providers
       |> Vec\map($$, $p ==> $p->getPathForClassMethod($class, $method))
+      |> Vec\filter_nulls($$)
       |> C\first($$);
   }
 
@@ -56,6 +60,7 @@ public function getPathForInterfaceMethod(
   ): ?string {
     return $this->providers
       |> Vec\map($$, $p ==> $p->getPathForInterfaceMethod($class, $method))
+      |> Vec\filter_nulls($$)
       |> C\first($$);
   }
 
@@ -65,12 +70,14 @@ public function getPathForTraitMethod(
   ): ?string {
     return $this->providers
       |> Vec\map($$, $p ==> $p->getPathForTraitMethod($trait, $method))
+      |> Vec\filter_nulls($$)
       |> C\first($$);
   }
 
   public function getPathForFunction(string $function): ?string {
     return $this->providers
       |> Vec\map($$, $p ==> $p->getPathForFunction($function))
+      |> Vec\filter_nulls($$)
       |> C\first($$);
   }
 

src/hh-apidoc-extensions/PathProvider.php

@@ -46,8 +46,7 @@ protected function getPathForClassishMethod(
     if ($class === null) {
       return null;
     }
-    $method = $class['methods'][$method] ?? null;
-    return $method === null ? null : $method['urlPath'];
+    return $class['methods'][$method]['urlPath'] ?? null;
   }
 
   public function getPathForFunction(string $function): ?string {