Calculate blame code for the HHClientLinter

Author: Atry

src/Linters/HHClientLinter.hack

@@ -10,7 +10,7 @@
 namespace Facebook\HHAST;
 
 use namespace Facebook\TypeAssert;
-use namespace HH\Lib\{C, Vec};
+use namespace HH\Lib\{C, Str, Vec};
 
 /**
  * A linter as a proxy invoking `hh_client --lint`.
@@ -25,6 +25,20 @@ final class HHClientLinter implements Linter {
     'version' => string,
   );
 
+  private static function blameCode(
+    vec<string> $file_lines,
+    HHClientLintError::TJSONError $error,
+  ): string {
+    $line_number_1base = $error['line'];
+    $line_index_0base = $line_number_1base - 1;
+    $line_content = $file_lines[$line_index_0base];
+    return Str\slice(
+      $line_content,
+      $error['start'],
+      $error['end'] - $error['start'],
+    );
+  }
+
   public async function getLintErrorsAsync(
   ): Awaitable<vec<HHClientLintError>> {
     $lines = await __Private\execute_async(
@@ -43,9 +57,14 @@ final class HHClientLinter implements Linter {
         \JSON_FB_HACK_ARRAYS,
       ),
     );
+    $file_lines = Str\split($this->getFile()->getContents(), "\n");
     return Vec\map(
       $hh_client_lint_result['errors'],
-      $error ==> new HHClientLintError($this->file, $error),
+      $error ==> new HHClientLintError(
+        $this->file,
+        $error,
+        $this::blameCode($file_lines, $error),
+      ),
     );
   }
 }

tests/examples/HHClientLinter/invalid_null_check.hack.expect

@@ -1,7 +1,7 @@
 [
     {
-        "blame": null,
-        "blame_pretty": null,
+        "blame": "cannot_be_null is null",
+        "blame_pretty": "cannot_be_null is null",
         "description": "Invalid null check: This expression will always return `false`.\nA value of type `int` can never be null."
     }
 ]