This repository has been archived by the owner on Aug 26, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 65
Does this project actually work? #33
Comments
@mjschultz yes it works. By the way this project haven't updated for a long time so I created fork with various fixes - https://github.com/lcd1232/django-postgrespool2 |
To be clear, this project does not work. Your fork should work because it adds back the |
@kennethreitz So... this project does not work? |
@lcd1232 can you send a pull request? |
@lcd1232 ping |
This project does not work - use the fork at https://github.com/lcd1232/django-postgrespool2. |
@lcd1232 any plan to send PR with fork's changes to this repo? |
Neither this or the fork work for me. (Using Django 2) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Looking at the code, it seems like
db_pool
is created at import to properly proxy to the sqlalchemy pool manager as expected.However, as of the changeset in https://github.com/kennethreitz/django-postgrespool/pull/21 it seems like the
db_pool
is no longer used to connect to the database and it should fallback to the default django psycopg2 drivers.The only reference to the
db_pool
object that should do the pooling magic is in the_dispose
method. So it seems like this is a simple wrapper around the default Django backend.Perhaps I am missing some DB-API knowledge or Django magic though?
The text was updated successfully, but these errors were encountered: