Skip to content
This repository has been archived by the owner on Aug 26, 2021. It is now read-only.

Does this project actually work? #33

Open
mjschultz opened this issue Apr 29, 2017 · 8 comments
Open

Does this project actually work? #33

mjschultz opened this issue Apr 29, 2017 · 8 comments

Comments

@mjschultz
Copy link

Looking at the code, it seems like db_pool is created at import to properly proxy to the sqlalchemy pool manager as expected.

However, as of the changeset in https://github.com/kennethreitz/django-postgrespool/pull/21 it seems like the db_pool is no longer used to connect to the database and it should fallback to the default django psycopg2 drivers.

The only reference to the db_pool object that should do the pooling magic is in the _dispose method. So it seems like this is a simple wrapper around the default Django backend.

Perhaps I am missing some DB-API knowledge or Django magic though?

@lcd1232
Copy link

lcd1232 commented Oct 11, 2017

@mjschultz yes it works. By the way this project haven't updated for a long time so I created fork with various fixes - https://github.com/lcd1232/django-postgrespool2

@mjschultz
Copy link
Author

To be clear, this project does not work.

Your fork should work because it adds back the get_new_connection that uses the db_pool.

@edevil
Copy link

edevil commented Jan 17, 2018

@kennethreitz So... this project does not work?

@kennethreitz
Copy link
Contributor

@lcd1232 can you send a pull request?

@edevil
Copy link

edevil commented Jan 30, 2018

@lcd1232 ping

@matthewh
Copy link

This project does not work - use the fork at https://github.com/lcd1232/django-postgrespool2.

@toanant
Copy link

toanant commented Jan 14, 2019

@lcd1232 any plan to send PR with fork's changes to this repo?

@vkolova
Copy link

vkolova commented May 1, 2019

Neither this or the fork work for me. (Using Django 2)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

No branches or pull requests

7 participants