Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misidentifying ]p #48

Open
Gumnos opened this issue Nov 26, 2024 · 5 comments
Open

Misidentifying ]p #48

Gumnos opened this issue Nov 26, 2024 · 5 comments
Labels
bug Something isn't working

Comments

@Gumnos
Copy link

Gumnos commented Nov 26, 2024

Created a comment with :help ]p and it linked to the help for p instead of ]p

FWIW, this feels familiar to #47, so like that issue, it might be an old-Reddit-only issue.

To Reproduce

  1. create a comment in r/vim containing :help ]p
  2. note that the VimHelpBot links to the help for p instead

Expected behavior

VimHelpBot links to help for ]p instead.

@Gumnos Gumnos added the bug Something isn't working label Nov 26, 2024
@Gumnos
Copy link
Author

Gumnos commented Nov 26, 2024

Adding a screenshot for clarity

2024-11-25-193701_813x217_scrot

@heraldofsolace
Copy link
Owner

Weird. It looks ok to me in both old and new Reddit. The fix for #47 replaces square brackets with fixed width square brackets which should not interfere with Markdown.

2024-11-27T21:13:19,277604044+05:30

Can you do an inspect element and see the generated HTML?

@Gumnos
Copy link
Author

Gumnos commented Nov 27, 2024

On further inspection, it looks like it may be linking to the right place (change.txt.html#%5Dp) but not displaying the right place (just the p). Viewing source on the page, I see

<ul>
<li><a href="https://vimhelp.org/change.txt.html#%5Dp" rel="nofollow"><code>]p</code></a> in <em>change.txt</em></li>
</ul>

the comments in question in case you want to poke at it too.

@heraldofsolace
Copy link
Owner

Yeah that is the correct markup. It works fine for me. Could it be that your font is missing the characters? Can you see the characters on this page? https://www.fileformat.info/info/unicode/char/ff3d/browsertest.htm

@Gumnos
Copy link
Author

Gumnos commented Nov 27, 2024

Nice troubleshooting! I copied/pasted that from Firefox's view-source into the Github issue, and it didn't render the not-a-right-square-bracket there either, so I thought it demonstrated the issue.

2024-11-27-111221_892x261_scrot

But looking at the same Reddit post and the Github issue-comment above in Chromium, that glyph does render correctly. So there's something about Firefox that fails to render that weird bracket.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants