Skip to content

Commit b57c093

Browse files
committed
Update release docs, and add missing ChangeLog entry
1 parent dee1f50 commit b57c093

File tree

3 files changed

+15
-5
lines changed

3 files changed

+15
-5
lines changed

ChangeLog.md

+1
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@
33
## 2.7.0.0
44

55
- Bindists for GHC 9.8.2
6+
- Enable many more plugins, making GHC 9.8.2 fully supported
67
- Fix refactor code actions for vim
78
- Preserve HLint's diagnostic severity
89
- Many other bug fixes.

RELEASING.md

+2-2
Original file line numberDiff line numberDiff line change
@@ -40,9 +40,9 @@
4040
- Afterwards, the artifacts are available at: `https://downloads.haskell.org/~hls/haskell-language-server-<version>/`
4141
- Run `SIGNING_KEY=... ../../release/upload.sh purge_all` to remove CDN caches
4242
- [ ] create PR to [ghcup-metadata](https://github.com/haskell/ghcup-metadata)
43-
- [ ] update `ghcup-0.0.7.yaml` and `ghcup-vanilla-0.0.7.yaml`
43+
- [ ] update `ghcup-vanilla-0.0.8.yaml` and `ghcup-vanilla-0.0.7.yaml`
4444
- can use `sh scripts/release/create-yaml-snippet.sh <version>` to generate a snippet that can be manually inserted into the yaml files
45-
- [ ] update `hls-metadata-0.0.1.json`
45+
- ~~update `hls-metadata-0.0.1.json`~~ Currently unnecessary, GHCup builds its own HLS binaries and updates that file.
4646
- utilize `cabal run ghcup-gen -- generate-hls-ghcs -f ghcup-0.0.7.yaml --format json --stdout` in the root of ghcup-metadata repository
4747
- Be sure to mark the correct latest version and add the 'recommended' tag to the latest release.
4848
- [ ] get sign-off on release

scripts/release/download-gh-artifacts.sh

+12-3
Original file line numberDiff line numberDiff line change
@@ -22,12 +22,21 @@ cd "gh-release-artifacts/haskell-language-server-${RELEASE}"
2222
# github
2323
gh release download "$RELEASE"
2424

25+
## We can't do cirrus releases any more, as we build HLS releases with ghcup vanilla binaries.
26+
## Vanilla means "upstream", aka GHC HQ, and GHC HQ does not provide bindists for FreeBSD.
27+
## Until we start using ghcup's mainstream distribution channel, we can't even begin to build
28+
## binaries for FreeBSD. We keep this here for the next generation or when the situation changes.
29+
##
30+
## We don't use ghcup's mainstream distribution channel, as we only provide vanilla binaries
31+
## as requested by the ghcup distribution channel team.
2532
# cirrus
26-
curl --fail -L -o "haskell-language-server-${RELEASE}-x86_64-freebsd.tar.xz" \
27-
"https://api.cirrus-ci.com/v1/artifact/github/haskell/haskell-language-server/bindist/bindist/out/haskell-language-server-${RELEASE}-x86_64-freebsd.tar.xz?branch=${RELEASE}"
33+
# curl --fail -L -o "haskell-language-server-${RELEASE}-x86_64-freebsd.tar.xz" \
34+
# "https://api.cirrus-ci.com/v1/artifact/github/haskell/haskell-language-server/bindist/bindist/out/haskell-language-server-${RELEASE}-x86_64-freebsd.tar.xz?branch=${RELEASE}"
2835

2936

3037
sha256sum haskell-language-server-* > SHA256SUMS
3138
gpg --detach-sign -u "${SIGNER}" SHA256SUMS
3239

33-
gh release upload "$RELEASE" "haskell-language-server-${RELEASE}-x86_64-freebsd.tar.xz" SHA256SUMS SHA256SUMS.sig
40+
## see comment above
41+
# gh release upload "$RELEASE" "haskell-language-server-${RELEASE}-x86_64-freebsd.tar.xz" SHA256SUMS SHA256SUMS.sig
42+
gh release upload "$RELEASE" SHA256SUMS SHA256SUMS.sig

0 commit comments

Comments
 (0)