Merge pull request #1012 from alanz/803-no-system-ghc

 hie-wrapper deals with missing System GHC

Author: alanz

app/HieWrapper.hs

@@ -83,7 +83,10 @@ run opts = do
 
   let
     hieBin = "hie-" ++ ghcVersion
-    backupHieBin = "hie-" ++ init (dropWhileEnd (/='.') ghcVersion)
+    backupHieBin =
+      case dropWhileEnd (/='.') ghcVersion of
+        [] -> "hie"
+        xs -> "hie-" ++ init xs
     candidates' = [hieBin, backupHieBin, "hie"]
     candidates = map (++ exeExtension) candidates'
 

src/Haskell/Ide/Engine/Plugin/Base.hs

@@ -105,22 +105,27 @@ hieGhcDisplayVersion = compilerName ++ "-" ++ VERSION_ghc
 
 getProjectGhcVersion :: IO String
 getProjectGhcVersion = do
-  isStackProject <- doesFileExist "stack.yaml"
+  isStackProject   <- doesFileExist "stack.yaml"
   isStackInstalled <- isJust <$> findExecutable "stack"
   if isStackProject && isStackInstalled
     then do
       L.infoM "hie" "Using stack GHC version"
       catch (tryCommand "stack ghc -- --numeric-version") $ \e -> do
         L.errorM "hie" $ show (e :: SomeException)
         L.infoM "hie" "Couldn't find stack version, falling back to plain GHC"
-        tryCommand "ghc --numeric-version"
+        getGhcVersion
     else do
       L.infoM "hie" "Using plain GHC version"
-      tryCommand "ghc --numeric-version"
+      getGhcVersion
 
   where
+    getGhcVersion = do
+      isGhcInstalled   <- isJust <$> findExecutable "ghc"
+      if isGhcInstalled
+        then tryCommand "ghc --numeric-version"
+        else return "No System GHC found"
+
     tryCommand cmd =
-      -- Drop '\n' from the output like "7.10.3\n", "8.4.3\n"
       init <$> readCreateProcess (shell cmd) ""
 
 hieGhcVersion :: String