Skip to content

Remove cert and pem enforcement #150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Remove cert and pem enforcement #150

Changes from 3 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
55cfd5a
add false value to kubernetes_ca_cert framework path | remove check t…
imthaghost Apr 21, 2022
2793dea
format
imthaghost Apr 21, 2022
3de105f
adjust framework path so pem_keys are marked as non-required
imthaghost Apr 21, 2022
0027a14
use the system pool and add the localCACert | test for default path
imthaghost Apr 22, 2022
36f8e8f
update test path
imthaghost Apr 26, 2022
486bee3
format
imthaghost Apr 26, 2022
a0dfafe
disable_local_ca_jwt to false
imthaghost Apr 26, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions path_config.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,7 @@ func pathConfig(b *kubeAuthBackend) *framework.Path {
DisplayAttrs: &framework.DisplayAttributes{
Name: "Kubernetes CA Certificate",
},
Required: false,
},
"token_reviewer_jwt": {
Type: framework.TypeString,
Expand All @@ -56,7 +57,9 @@ extracted. Not every installation of Kubernetes exposes these keys.`,
DisplayAttrs: &framework.DisplayAttributes{
Name: "Service account verification keys",
},
Required: false,
},

"issuer": {
Type: framework.TypeString,
Deprecated: true,
Expand Down Expand Up @@ -141,10 +144,6 @@ func (b *kubeAuthBackend) pathConfigWrite(ctx context.Context, req *logical.Requ
}
}

if disableLocalJWT && caCert == "" {
return logical.ErrorResponse("kubernetes_ca_cert must be given when disable_local_ca_jwt is true"), nil
}

config := &kubeConfig{
PublicKeys: make([]interface{}, len(pemList)),
PEMKeys: pemList,
Expand Down