Use an enum instead of string and update tests

Author: dak1n1

helper/schema/schema.go

@@ -199,11 +199,13 @@ type Schema struct {
 	RequiredWith  []string
 
 	// ConditionsMode specifies the behavior of the SDK when one of the
-	// above conditions are met. (ConflictsWith, ExactlyOneOf, etc).
-	// When set to WARNING, a warning message is displayed to the user.
-	// When set to ERROR (default), a fatal error is returned.
-	// Optionally, a message can be returned with the warning or error.
-	ConditionsMode    string
+	// above conditions are met (ConflictsWith, ExactlyOneOf, etc).
+	// The default value is SchemaConditionsModeError, which returns an error.
+	// Set ConditionsMode to SchemaConditionsModeWarning to return a warning instead.
+	//
+	// ConditionsModeMessage can optionally be used to display a message
+	// to the user when one of the above conditions are met.
+	ConditionsMode    SchemaConditionsMode
 	ConditionsMessage string
 
 	// When Deprecated is set, this attribute is deprecated.
@@ -263,6 +265,13 @@ const (
 	SchemaConfigModeBlock
 )
 
+type SchemaConditionsMode uint8
+
+const (
+	SchemaConditionsModeError   SchemaConditionsMode = 0
+	SchemaConditionsModeWarning SchemaConditionsMode = 1
+)
+
 // SchemaDiffSuppressFunc is a function which can be used to determine
 // whether a detected diff on a schema element is "valid" or not, and
 // suppress it from the plan if necessary.
@@ -1457,17 +1466,10 @@ func (m schemaMap) validate(
 		ok = raw != nil
 	}
 
-	var conditionsMode diag.Severity
-	if schema.ConditionsMode == strings.ToLower("warning") {
-		conditionsMode = diag.Warning
-	} else {
-		conditionsMode = diag.Error
-	}
-
 	err := validateExactlyOneAttribute(k, schema, c)
 	if err != nil {
 		return append(diags, diag.Diagnostic{
-			Severity:      conditionsMode,
+			Severity:      diag.Severity(schema.ConditionsMode),
 			Summary:       "ExactlyOne",
 			Detail:        fmt.Sprintf("%s %s", schema.ConditionsMessage, err.Error()),
 			AttributePath: path,
@@ -1477,7 +1479,7 @@ func (m schemaMap) validate(
 	err = validateAtLeastOneAttribute(k, schema, c)
 	if err != nil {
 		return append(diags, diag.Diagnostic{
-			Severity:      conditionsMode,
+			Severity:      diag.Severity(schema.ConditionsMode),
 			Summary:       "AtLeastOne",
 			Detail:        fmt.Sprintf("%s %s", schema.ConditionsMessage, err.Error()),
 			AttributePath: path,
@@ -1509,7 +1511,7 @@ func (m schemaMap) validate(
 	err = validateRequiredWithAttribute(k, schema, c)
 	if err != nil {
 		return append(diags, diag.Diagnostic{
-			Severity:      conditionsMode,
+			Severity:      diag.Severity(schema.ConditionsMode),
 			Summary:       "RequiredWith",
 			Detail:        fmt.Sprintf("%s %s", schema.ConditionsMessage, err.Error()),
 			AttributePath: path,
@@ -1536,7 +1538,7 @@ func (m schemaMap) validate(
 	err = validateConflictingAttributes(k, schema, c)
 	if err != nil {
 		return append(diags, diag.Diagnostic{
-			Severity:      conditionsMode,
+			Severity:      diag.Severity(schema.ConditionsMode),
 			Summary:       "ConflictsWith",
 			Detail:        fmt.Sprintf("%s %s", schema.ConditionsMessage, err.Error()),
 			AttributePath: path,