Skip to content

Commit 2dcbfb8

Browse files
authored
Fixes for review feedback (#4)
* splits `dependencies` and `devDependencies` in a better way * updates `ncc` settings to build without cache and skips creating `LICENSE` file * addresses review feedback
1 parent e4b0c3a commit 2dcbfb8

8 files changed

+1861
-1463
lines changed

README.md

+6-6
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,10 @@
1-
# setup-nomad-pack
1+
# GitHub Action: setup-nomad-pack
22

33
The `hashicorp/setup-nomad-pack` Action sets up the `nomad-pack` CLI in your GitHub Actions workflow by adding the binary to `PATH`.
44

55
## Table of Contents
66

7-
- [setup-nomad-pack](#setup-nomad-pack)
7+
- [GitHub Action: setup-nomad-pack](#github-action-setup-nomad-pack)
88
- [Table of Contents](#table-of-contents)
99
- [Requirements](#requirements)
1010
- [Usage](#usage)
@@ -36,7 +36,7 @@ Optionally, set any and all [environment variables](https://www.nomadproject.io/
3636
<small>GitHub Actions run on a publicly-known list of [IP addresses](https://docs.github.com/en/actions/using-github-hosted-runners/about-github-hosted-runners#ip-addresses).
3737
This data may be retrieved through [HashiCorp Terraform](https://terraform.io/), using the [ip_ranges data source](https://registry.terraform.io/providers/integrations/github/latest/docs/data-sources/ip_ranges), allowing you to make IP-address _one_ of the security considerations.</small>
3838

39-
2.) Create a GitHub Actions Workflow file (e.g.: `.github/workflows/nomad-pack.yml):
39+
2.) Create a GitHub Actions Workflow file (e.g.: `.github/workflows/nomad-pack.yml`):
4040

4141
```yaml
4242
name: nomad-pack
@@ -57,7 +57,7 @@ jobs:
5757
uses: hashicorp/[email protected]
5858
id: setup
5959
with:
60-
version: "0.0.1-techpreview2"
60+
version: "0.0.1-techpreview2" # or `latest`
6161

6262
- name: Run `nomad-pack info` for `simple_service`
6363
id: info
@@ -87,7 +87,7 @@ Additionally, you may configure [outputs](https://docs.github.com/en/actions/usi
8787

8888
This section contains a list of all inputs that may be set for this Action.
8989

90-
- `version` - (required) The version of `nomad-pack` to install. Supports [semver](https://www.npmjs.com/package/semver) versioning. Defaults to `0.0.1-techpreview2`.
90+
- `version` - (required) The version of `nomad-pack` to install. Supports [semver](https://www.npmjs.com/package/semver) versioning. Defaults to `latest`.
9191

9292
## Outputs
9393

@@ -97,7 +97,7 @@ This section contains a list of all outputs that can be consumed from this Actio
9797

9898
## Author Information
9999

100-
This module is maintained by the contributors listed on [GitHub](https://github.com/hashicorp/setup-nomad-pack/graphs/contributors).
100+
This GitHub Action is maintained by the contributors listed on [GitHub](https://github.com/hashicorp/setup-nomad-pack/graphs/contributors).
101101

102102
The original code of this repository is based on work done by [Matthew Sanabria](https://github.com/sudomateo) as part of the [setup-packer](https://github.com/sudomateo/setup-packer) GitHub Action.
103103

action.yml

+4-4
Original file line numberDiff line numberDiff line change
@@ -2,15 +2,15 @@
22

33
name: "Setup HashiCorp Nomad Pack"
44
author: "Kerim Satirli"
5-
description: "A GitHub Action to install a specific version of HashiCorp nomad-pack and add it to PATH."
5+
description: "A GitHub Action to install a specific version of HashiCorp Nomad Pack and add it to PATH."
66
inputs:
77
version:
8-
description: "The nomad-pack version to install and add to PATH. Supports semver versioning."
8+
description: "The Nomad Pack version to install and add to PATH."
99
required: true
10-
default: "0.0.1-techpreview2"
10+
default: "latest"
1111
outputs:
1212
version:
13-
description: "The nomad-pack version that was installed and added to PATH."
13+
description: "The Nomad Pack version that was installed and added to PATH."
1414
runs:
1515
using: "node16"
1616
main: "dist/index.js"

dist/LICENSE

-657
This file was deleted.

0 commit comments

Comments
 (0)