Skip to content

Commit 686c853

Browse files
committed
use quick way to fix the close modal animation issue.
see: valor-software#6565
1 parent 6682c25 commit 686c853

File tree

1 file changed

+3
-1
lines changed

1 file changed

+3
-1
lines changed

src/modal/bs-modal.service.ts

+3-1
Original file line numberDiff line numberDiff line change
@@ -141,7 +141,9 @@ export class BsModalService {
141141
.provide({ provide: BsModalRef, useValue: bsModalRef })
142142
.attach(ModalContainerComponent)
143143
.to('body');
144-
bsModalRef.hide = () => this.hide(bsModalRef.id);
144+
// use quick way to fix the animate issue for now
145+
// see: https://github.com/valor-software/ngx-bootstrap/pull/6565
146+
bsModalRef.hide = () => modalContainerRef.instance?.hide();
145147
bsModalRef.setClass = (newClass: string) => {
146148
if (modalContainerRef.instance) {
147149
modalContainerRef.instance.config.class = newClass;

0 commit comments

Comments
 (0)