Skip to content

Commit f0c833f

Browse files
committed
MINOR: quic: Add useful error traces about qc_ssl_sess_init() failures
There were no traces to diagnose qc_ssl_sess_init() failures from QUIC traces. This patch add calls to TRACE_DEVEL() into qc_ssl_sess_init() and its caller (qc_alloc_ssl_sock_ctx()). This was useful at least to diagnose SSL context initialization failures when porting QUIC to the new OpenSSL 3.5 QUIC API. Should be easily backported as far as 2.6.
1 parent d96368b commit f0c833f

File tree

1 file changed

+6
-2
lines changed

1 file changed

+6
-2
lines changed

src/quic_ssl.c

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -878,7 +878,7 @@ static int qc_ssl_sess_init(struct quic_conn *qc, SSL_CTX *ssl_ctx, SSL **ssl)
878878
*ssl = SSL_new(ssl_ctx);
879879
if (!*ssl) {
880880
if (!retry--)
881-
goto leave;
881+
goto err;
882882

883883
pool_gc(NULL);
884884
goto retry;
@@ -889,7 +889,7 @@ static int qc_ssl_sess_init(struct quic_conn *qc, SSL_CTX *ssl_ctx, SSL **ssl)
889889
SSL_free(*ssl);
890890
*ssl = NULL;
891891
if (!retry--)
892-
goto leave;
892+
goto err;
893893

894894
pool_gc(NULL);
895895
goto retry;
@@ -899,6 +899,9 @@ static int qc_ssl_sess_init(struct quic_conn *qc, SSL_CTX *ssl_ctx, SSL **ssl)
899899
leave:
900900
TRACE_LEAVE(QUIC_EV_CONN_NEW, qc);
901901
return ret;
902+
err:
903+
TRACE_DEVEL("leaving on error", QUIC_EV_CONN_NEW, qc);
904+
goto leave;
902905
}
903906

904907
#ifdef HAVE_SSL_0RTT_QUIC
@@ -996,6 +999,7 @@ int qc_alloc_ssl_sock_ctx(struct quic_conn *qc)
996999
return !ret;
9971000

9981001
err:
1002+
TRACE_DEVEL("leaving on error", QUIC_EV_CONN_NEW, qc);
9991003
pool_free(pool_head_quic_ssl_sock_ctx, ctx);
10001004
goto leave;
10011005
}

0 commit comments

Comments
 (0)