MEDIUM: add findserver with only one conversion

Author: ivanmatmati

configuration/server.go

@@ -874,17 +874,11 @@ func SerializeServer(s models.Server, opt *options.ConfigurationOptions) types.S
 }
 
 func GetServerByName(name string, parentType string, parentName string, p parser.Parser) (*models.Server, int) {
-	servers, err := ParseServers(parentType, parentName, p)
+	server, i, err := FindServers(parentType, parentName, name, p)
 	if err != nil {
-		return nil, 0
+		return nil, i
 	}
-
-	for i, s := range servers {
-		if s.Name == name {
-			return s, i
-		}
-	}
-	return nil, 0
+	return server, i
 }
 
 func sectionType(parentType string) parser.Section {
@@ -899,3 +893,26 @@ func sectionType(parentType string) parser.Section {
 	}
 	return sectionType
 }
+
+func FindServers(parentType string, parentName string, serverName string, p parser.Parser) (*models.Server, int, error) {
+	data, err := p.Get(sectionType(parentType), parentName, "server", false)
+	if err != nil {
+		if errors.Is(err, parser_errors.ErrFetch) {
+			return nil, 0, nil
+		}
+		return nil, 0, err
+	}
+
+	ondiskServers, ok := data.([]types.Server)
+	if !ok {
+		return nil, 0, misc.CreateTypeAssertError("server")
+	}
+
+	for i, ondiskServer := range ondiskServers {
+		if ondiskServer.Name == serverName {
+			return ParseServer(ondiskServer), i, nil
+		}
+	}
+
+	return nil, 0, nil
+}