Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Close JsonWriters. Caused speed up? #149

Closed
gjvanderheiden opened this issue Nov 18, 2021 · 1 comment · Fixed by #158
Closed

Close JsonWriters. Caused speed up? #149

gjvanderheiden opened this issue Nov 18, 2021 · 1 comment · Fixed by #158

Comments

@gjvanderheiden
Copy link
Contributor

see:
[#148]

I use hap-java for my entire house. Everything is KNX, so pretty much accessories. Sometimes the accessories turn red and says "device not responding" (or something like that, get it in dutch). Also sometimes it takes a while, which makes no sense, because I cache all KNX values. I use a version with another pr request in it [#130]. Also I updated all dependencies in my local build of HAP-Java. No "device not responding" anymore and seems to react a lot faster.

So I'm not sure if closing JsonWriters did the trick. It can't hurt also. And in the close() operation of JsonWriter you see a flush. ByteArrayBuffer was closed, but that doesn't do anything.

I stole this idea from pr [#116]. That pr fixed it on one occurrence, but I found 3 more, by searching on usages of createWriter().

@gjvanderheiden
Copy link
Contributor Author

Started my own hap implementation, pr requests are merged waaaay to slow.

@yfre yfre linked a pull request Feb 5, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant