Skip to content

[FE] ReactMarkdown의 children prop 사용 개선 #227

@junglesub

Description

@junglesub

⚠️ Potential issue

ReactMarkdown의 children prop 사용 개선

ReactMarkdown에서 children prop 사용은 권장되지 않습니다. 대신 직접 content를 전달하세요.

-      <ReactMarkdown
-        children={content}
+      <ReactMarkdown

그리고 닫는 태그 전에 content를 추가:

-      />
+      >
+        {content}
+      </ReactMarkdown>
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

      <ReactMarkdown>
        {content}
      </ReactMarkdown>
🧰 Tools
🪛 Biome (1.9.4)

[error] 19-19: Avoid passing children using a prop

The canonical way to pass children in React is to use JSX elements

(lint/correctness/noChildrenProp)

🤖 Prompt for AI Agents
In src/main/front/src/components/NodeGroupPage/MarkdownViwer.tsx at line 19,
replace the usage of the ReactMarkdown component's children prop with passing
the content directly as a prop. Remove the children={content} syntax and instead
place the content between the opening and closing tags of ReactMarkdown to
comply with recommended usage.

Originally posted by @coderabbitai[bot] in #226 (comment)

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    Status

    Done

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions