-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding recognizers dynamically #1005
Comments
This is functionality we decided to add directly to the library probably in V3 |
Neat! Based on my work, or a new implementation? I'd be happy to contribute/maintain the code. I've learned a lot about the nuances of these types of gestures during my work on the game, which is a high budget production set to release in a few weeks... :) |
@OpherV V3 is a complete re-write so not sure how direct it would transfer but we would love your help! |
Also the ability to add and remove recognizers has always been planned and will be in v3 to allow custom builds. |
Alrighty then - I'll stay tuned. |
We do most of our planning and discussion on slack feel free to join us |
@arschmitz @runspired Like I promised it's finally out! http://pistons.com/1on1?forcetouch=true Check it out :) |
@OpherV What an awesome game!!! |
Hi, I'm the author of #991 (SVG path trace recognizer)
tl;dr I suggest an enhancement to allow recognizer plugins for Hammer.js
Originally, and like I wrote in the PR comment, Hammer architecture currently does not easily allow adding recognizers dynamically. It assumes all recognizers are pre-packed with the lib, which makes it harder to write external modules. This means that extra functionality that might be relevant to some but not all use cases will either be deemed too out of scope and thus not included with hammer, or get included and bloat up the core lib.
Use case: Other than the SVG path follow I've already implemented, I'm also working on implementing an arbitrary shape/stroke recognizer based on $1 unistroke recognizer. This is a very specific use case that relies on an external library, with a different license than that of Hammerjs. It would be cool if Hammer could support it via external plugins, but without having to include both the implementation and the library in the source code.
The text was updated successfully, but these errors were encountered: