Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logger can't serialize BigInt II #229

Open
pixtron opened this issue Jan 22, 2020 · 0 comments
Open

Logger can't serialize BigInt II #229

pixtron opened this issue Jan 22, 2020 · 0 comments

Comments

@pixtron
Copy link
Member

pixtron commented Jan 22, 2020

Describe the bug

If a BigInt is logged logger throws TypeError: Do not know how to serialize a BigInt

To Reproduce

logger.info('Logging BigInt', {number: BigInt('32')});

Expected behavior

Should Serialize bigInt to string.

Environment

  • desktop client version: v1.3.x (4b83690)

Additional context

Also see: #228

Uncaught TypeError: Do not know how to serialize a BigInt
    at JSON.stringify (<anonymous>)
    at Format.transform (/Users/.../balloon-client-desktop/app/lib/logger-factory.js:21)
    at Format.transform (/Users/.../balloon-client-desktop/node_modules/logform/combine.js:20)
    at File._write (/Users/.../balloon-client-desktop/node_modules/winston-transport/index.js:90)
@pixtron pixtron added the bug label Jan 22, 2020
pixtron added a commit that referenced this issue Jan 22, 2020
@pixtron pixtron added the hasfix label Jan 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant