Skip to content

Commit 468bf52

Browse files
authored
Undo the disable of source maps for non-chrome browsers (#9941)
Nowadays, all modern browsers support sourcemaps by default, so there is no need to have exception configuration anymore. Fixes #9759
1 parent 9be7196 commit 468bf52

File tree

3 files changed

+7
-21
lines changed

3 files changed

+7
-21
lines changed

user/src/com/google/gwt/core/CoreWithUserAgent.gwt.xml

Lines changed: 0 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -15,20 +15,4 @@
1515
<!-- Deferred binding rules for core classes based on user agent. -->
1616
<module>
1717
<inherits name="com.google.gwt.core.Core"/>
18-
19-
<!-- Disable source maps for non-Chrome browsers -->
20-
<!-- TODO(goktug): enable source maps for non-Chrome browsers -->
21-
<set-property name="compiler.useSourceMaps" value="false">
22-
<none>
23-
<when-property-is name="user.agent" value="safari"/>
24-
</none>
25-
</set-property>
26-
27-
<replace-with class="com.google.gwt.core.client.impl.StackTraceCreator.CollectorModern">
28-
<when-type-is class="com.google.gwt.core.client.impl.StackTraceCreator.Collector" />
29-
<when-property-is name="compiler.stackMode" value="native" />
30-
<when-property-is name="user.agent" value="safari" />
31-
<when-property-is name="compiler.useSourceMaps" value="true"/>
32-
</replace-with>
33-
3418
</module>

user/src/com/google/gwt/core/StackTrace.gwt.xml

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -45,9 +45,14 @@
4545
<when-property-is name="compiler.stackMode" value="native" />
4646
</replace-with>
4747

48-
4948
<replace-with class="com.google.gwt.core.client.impl.StackTraceCreator.CollectorNull">
5049
<when-type-is class="com.google.gwt.core.client.impl.StackTraceCreator.Collector" />
5150
<when-property-is name="compiler.stackMode" value="strip" />
5251
</replace-with>
52+
53+
<replace-with class="com.google.gwt.core.client.impl.StackTraceCreator.CollectorModern">
54+
<when-type-is class="com.google.gwt.core.client.impl.StackTraceCreator.Collector" />
55+
<when-property-is name="compiler.stackMode" value="native" />
56+
<when-property-is name="compiler.useSourceMaps" value="true"/>
57+
</replace-with>
5358
</module>

user/test/com/google/gwt/user/LoggingRPCSuite.gwt.xml

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -30,12 +30,9 @@
3030
</set-property>
3131

3232
<!-- when stack trace stripping is enabled, we need to replace the Null collector
33-
with one that does something for Chrome -->
33+
with one that does something -->
3434
<replace-with class="com.google.gwt.core.client.impl.StackTraceCreator.CollectorChrome">
3535
<when-type-is class="com.google.gwt.core.client.impl.StackTraceCreator.Collector" />
36-
<!-- For now, only Chrome provides Error.stack support, so we hijack the
37-
entire WebKit permutation -->
38-
<when-property-is name="user.agent" value="safari" />
3936
<when-property-is name="compiler.useSourceMaps" value="true" />
4037
</replace-with>
4138

0 commit comments

Comments
 (0)