The source does not compile with hardened compilation

[AndersonTorres]

Hello! I am Anderson, a Nixpkgs commmiter.

When I was writing the expression, the compiler terminated with an error message related to "warnings treated as errors". I circumvented it by loosening the compiler constraints.

Here is the output of compilation with format-security enabled:

build flags: SHELL=/nix/store/cwnwyy82wrq53820z6yg7869z8dl5s7g-bash-4.4-p23/bin/bash
Making all in Source
make[1]: Entering directory '/mnt/sources/z-sandbox/0-descartavel/source/Source'
make  all-am
make[2]: Entering directory '/mnt/sources/z-sandbox/0-descartavel/source/Source'
gcc -DHAVE_CONFIG_H -I.     -g -O2 -MT optioncheck.o -MD -MP -MF .deps/optioncheck.Tpo -c -o optioncheck.o optioncheck.c
mv -f .deps/optioncheck.Tpo .deps/optioncheck.Po
gcc -DHAVE_CONFIG_H -I.     -g -O2 -MT analyser.o -MD -MP -MF .deps/analyser.Tpo -c -o analyser.o analyser.c
mv -f .deps/analyser.Tpo .deps/analyser.Po
gcc -DHAVE_CONFIG_H -I.     -g -O2 -MT generator.o -MD -MP -MF .deps/generator.Tpo -c -o generator.o generator.c
generator.c: In function ‘Generate_Item’:
generator.c:2051:13: warning: ignoring return value of ‘system’ declared with attribute ‘warn_unused_result’ [-Wunused-result]
 2051 |             system( line );
      |             ^~~~~~~~~~~~~~
mv -f .deps/generator.Tpo .deps/generator.Po
gcc -DHAVE_CONFIG_H -I.     -g -O2 -MT headers.o -MD -MP -MF .deps/headers.Tpo -c -o headers.o headers.c
mv -f .deps/headers.Tpo .deps/headers.Po
gcc -DHAVE_CONFIG_H -I.     -g -O2 -MT headertypes.o -MD -MP -MF .deps/headertypes.Tpo -c -o headertypes.o headertypes.c
mv -f .deps/headertypes.Tpo .deps/headertypes.Po
gcc -DHAVE_CONFIG_H -I.     -g -O2 -MT items.o -MD -MP -MF .deps/items.Tpo -c -o items.o items.c
mv -f .deps/items.Tpo .deps/items.Po
gcc -DHAVE_CONFIG_H -I.     -g -O2 -MT links.o -MD -MP -MF .deps/links.Tpo -c -o links.o links.c
mv -f .deps/links.Tpo .deps/links.Po
gcc -DHAVE_CONFIG_H -I.     -g -O2 -MT globals.o -MD -MP -MF .deps/globals.Tpo -c -o globals.o globals.c
mv -f .deps/globals.Tpo .deps/globals.Po
gcc -DHAVE_CONFIG_H -I.     -g -O2 -MT robodoc.o -MD -MP -MF .deps/robodoc.Tpo -c -o robodoc.o robodoc.c
mv -f .deps/robodoc.Tpo .deps/robodoc.Po
gcc -DHAVE_CONFIG_H -I.     -g -O2 -MT util.o -MD -MP -MF .deps/util.Tpo -c -o util.o util.c
util.c: In function ‘RB_ReadWholeLine’:
util.c:1037:9: warning: ignoring return value of ‘fgets’ declared with attribute ‘warn_unused_result’ [-Wunused-result]
 1037 |         fgets( buf, MAX_LINE_LEN, file );
      |         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
util.c: In function ‘RB_Change_Back_To_CWD’:
util.c:1199:9: warning: ignoring return value of ‘chdir’ declared with attribute ‘warn_unused_result’ [-Wunused-result]
 1199 |         chdir( cwd );
      |         ^~~~~~~~~~~~
util.c: In function ‘RB_Change_To_Docdir’:
util.c:1227:5: warning: ignoring return value of ‘getcwd’ declared with attribute ‘warn_unused_result’ [-Wunused-result]
 1227 |     getcwd( tmp, sizeof( tmp ) );
      |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
util.c:1234:5: warning: ignoring return value of ‘chdir’ declared with attribute ‘warn_unused_result’ [-Wunused-result]
 1234 |     chdir( tmp );
      |     ^~~~~~~~~~~~
mv -f .deps/util.Tpo .deps/util.Po
gcc -DHAVE_CONFIG_H -I.     -g -O2 -MT html_generator.o -MD -MP -MF .deps/html_generator.Tpo -c -o html_generator.o html_generator.c
mv -f .deps/html_generator.Tpo .deps/html_generator.Po
gcc -DHAVE_CONFIG_H -I.     -g -O2 -MT xmldocbook_generator.o -MD -MP -MF .deps/xmldocbook_generator.Tpo -c -o xmldocbook_generator.o xmldocbook_generator.c
mv -f .deps/xmldocbook_generator.Tpo .deps/xmldocbook_generator.Po
gcc -DHAVE_CONFIG_H -I.     -g -O2 -MT latex_generator.o -MD -MP -MF .deps/latex_generator.Tpo -c -o latex_generator.o latex_generator.c
mv -f .deps/latex_generator.Tpo .deps/latex_generator.Po
gcc -DHAVE_CONFIG_H -I.     -g -O2 -MT rtf_generator.o -MD -MP -MF .deps/rtf_generator.Tpo -c -o rtf_generator.o rtf_generator.c
mv -f .deps/rtf_generator.Tpo .deps/rtf_generator.Po
gcc -DHAVE_CONFIG_H -I.     -g -O2 -MT test_generator.o -MD -MP -MF .deps/test_generator.Tpo -c -o test_generator.o test_generator.c
mv -f .deps/test_generator.Tpo .deps/test_generator.Po
gcc -DHAVE_CONFIG_H -I.     -g -O2 -MT ascii_generator.o -MD -MP -MF .deps/ascii_generator.Tpo -c -o ascii_generator.o ascii_generator.c
mv -f .deps/ascii_generator.Tpo .deps/ascii_generator.Po
gcc -DHAVE_CONFIG_H -I.     -g -O2 -MT troff_generator.o -MD -MP -MF .deps/troff_generator.Tpo -c -o troff_generator.o troff_generator.c
troff_generator.c: In function ‘RB_TROFF_Generate_Item_Line_Number’:
troff_generator.c:563:5: error: format not a string literal and no format arguments [-Werror=format-security]
  563 |     fprintf( dest_doc, line_number_string );
      |     ^~~~~~~
troff_generator.c: In function ‘RB_TROFF_Generate_Header_Start’:
troff_generator.c:226:13: warning: ignoring return value of ‘symlink’ declared with attribute ‘warn_unused_result’ [-Wunused-result]
  226 |             symlink( basename( manpage ), buf );
      |             ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
cc1: some warnings being treated as errors
make[2]: *** [makefile:461: troff_generator.o] Error 1
make[2]: Leaving directory '/mnt/sources/z-sandbox/0-descartavel/source/Source'
make[1]: *** [makefile:323: all] Error 2
make[1]: Leaving directory '/mnt/sources/z-sandbox/0-descartavel/source/Source'
make: *** [makefile:540: all-recursive] Error 1

Disabling this flag the project runs fine.

[gumpu]

Thanks for the feedback! Will be fixed in the next release.