Fix: Avoid false positive reporting of sync tasks on errors (fixes #162) (#204)

Author: stof

lib/versioned/^4.0.0-alpha.1/index.js

@@ -29,7 +29,7 @@ function execute(opts, env, config) {
 
   var gulpInst = require(env.modulePath);
   logEvents(gulpInst);
-  logSyncTask(gulpInst);
+  logSyncTask(gulpInst, opts);
 
   // This is what actually loads up the gulpfile
   var exported = require(env.configPath);

lib/versioned/^4.0.0-alpha.2/index.js

@@ -30,7 +30,7 @@ function execute(opts, env, config) {
 
   var gulpInst = require(env.modulePath);
   logEvents(gulpInst);
-  logSyncTask(gulpInst);
+  logSyncTask(gulpInst, opts);
 
   // This is what actually loads up the gulpfile
   var exported = require(env.configPath);

lib/versioned/^4.0.0/index.js

@@ -30,7 +30,7 @@ function execute(opts, env, config) {
 
   var gulpInst = require(env.modulePath);
   logEvents(gulpInst);
-  logSyncTask(gulpInst);
+  logSyncTask(gulpInst, opts);
 
   // This is what actually loads up the gulpfile
   var exported = require(env.configPath);

lib/versioned/^4.0.0/log/sync-task.js

@@ -35,12 +35,18 @@ function clear(e) {
   delete tasks[e.uid];
 }
 
-function logSyncTask(gulpInst) {
+function clearAll() {
+  tasks = {};
+}
+
+function logSyncTask(gulpInst, opts) {
 
   process.once('exit', warn);
   gulpInst.on('start', start);
   gulpInst.on('stop', clear);
-  gulpInst.on('error', clear);
+  // When not running in --continue mode, we need to clear everything on error to avoid
+  // false positives.
+  gulpInst.on('error', opts.continue ? clear : clearAll);
 }
 
 module.exports = logSyncTask;

test/fixtures/gulpfiles/gulpfile-parallel-failure.js

@@ -0,0 +1,18 @@
+'use strict';
+
+var gulp = require('gulp');
+
+function noop(cb) {
+  cb();
+}
+
+function errorFunction(cb) {
+  cb(new Error('Error!'));
+}
+
+function notCompleting1() {
+  // Callback is not called
+}
+
+gulp.task('default', gulp.parallel(errorFunction, noop));
+gulp.task('broken', gulp.parallel(errorFunction, noop, notCompleting1));

test/non-completing-tasks.js

@@ -33,4 +33,31 @@ describe('sync-task', function() {
         done();
       });
   });
+
+  it('should not log false positive in case of parallel failure', function(done) {
+    runner({ verbose: false })
+      .gulp('--gulpfile ./test/fixtures/gulpfiles/gulpfile-parallel-failure.js')
+      .run(function(err, stdout) {
+        expect(stdout).toExclude('The following tasks did not complete:');
+        done();
+      });
+  });
+
+  it('should not log false positive in case of parallel failure in continue mode', function(done) {
+    runner({ verbose: false })
+      .gulp('--continue --gulpfile ./test/fixtures/gulpfiles/gulpfile-parallel-failure.js')
+      .run(function(err, stdout) {
+        expect(stdout).toExclude('The following tasks did not complete:');
+        done();
+      });
+  });
+
+  it('should log non-completing task alongside a failure in continue mode', function(done) {
+    runner({ verbose: false })
+      .gulp('--continue --gulpfile ./test/fixtures/gulpfiles/gulpfile-parallel-failure.js broken')
+      .run(function(err, stdout) {
+        expect(stdout).toInclude('The following tasks did not complete: broken, notCompleting1\n');
+        done();
+      });
+  });
 });