Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TextField crashes app when pasting unicode surrogate pair #3966

Open
tznind opened this issue Mar 8, 2025 · 1 comment · May be fixed by #3982
Open

TextField crashes app when pasting unicode surrogate pair #3966

tznind opened this issue Mar 8, 2025 · 1 comment · May be fixed by #3982
Labels
bug
Milestone
V2 Alpha

Comments

@tznind
Copy link
Collaborator

tznind commented Mar 8, 2025 •
edited
Loading

Describe the bug
When pasting a 2 char pair e.g. 📄 the TextField crashes with following exception:

System.ArgumentOutOfRangeException
Specified argument was out of the range of valid values. (Parameter 'value')
   at System.Text.Rune..ctor(UInt32 value)
   at Terminal.Gui.Key.ToRune(KeyCode key) in D:\Repos\temp\gui.cs\Terminal.Gui\Input\Keyboard\Key.cs:line 349
   at Terminal.Gui.Key.get_AsRune() in D:\Repos\temp\gui.cs\Terminal.Gui\Input\Keyboard\Key.cs:line 156
   at Terminal.Gui.TextField.InsertText(Key a, Boolean usePreTextChangedCursorPos) in D:\Repos\temp\gui.cs\Terminal.Gui\Views\TextField.cs:line 1389
   at Terminal.Gui.TextField.InsertText(String toAdd, Boolean useOldCursorPos) in D:\Repos\temp\gui.cs\Terminal.Gui\Views\TextField.cs:line 750
   at Terminal.Gui.ViewsTests.TextFieldTests.TestPasteUnicodeTextField() in D:\Repos\temp\gui.cs\Tests\UnitTests\Views\TextFieldTests.cs:line 1982
   at System.RuntimeMethodHandle.InvokeMethod(Object target, Void** arguments, Signature sig, Boolean isConstructor)
   at System.Reflection.MethodBaseInvoker.InvokeWithNoArgs(Object obj, BindingFlags invokeAttr)

To Reproduce
Steps to reproduce the behavior:

    [Fact]
    public void TestPasteUnicodeTextField ()
    {
        var tf = new TextField ();
        //📄
        tf.InsertText ("\ud83d\udcc4");

    }

Expected behavior
If it is not supported by Terminal.Gui then ignore the paste i.e. paste nothing
@tznind tznind added the bug label Mar 8, 2025
@tig tig added this to the V2 Alpha milestone Mar 8, 2025
@BDisp
Copy link
Collaborator

BDisp commented Mar 10, 2025

TextField doesn't use the InsertText method to paste from the clipboard but use the Paste method setting the Text property directly, beside the TextField displaying the replacement character. But the InsertText method should also be able to process it. So, it needed to process as rune and not as char.

@BDisp BDisp linked a pull request Mar 12, 2025 that will close this issue
Draft
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
Terminal.Gui V2 Initial Release
Status: No status
Milestone
V2 Alpha
Development

Successfully merging a pull request may close this issue.

Fixes # 3966. TextField crashes app when pasting unicode surrogate pair BDisp/Terminal.Gui
3 participants
@tig @BDisp @tznind