Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deduplicate code to fetch localized strings and elements #12

Open
hanrodz opened this issue Oct 30, 2024 · 0 comments · May be fixed by #14
Open

Deduplicate code to fetch localized strings and elements #12

hanrodz opened this issue Oct 30, 2024 · 0 comments · May be fixed by #14
Assignees
@hanrodz
Labels
enhancement New feature or request

Comments

@hanrodz
Copy link
Member

hanrodz commented Oct 30, 2024 •
edited
Loading

The logic in getLocalizedElement and getLocalizedString is the same except one returns a string and the other an element object. Abstract into a single method both methods call while ensuring type safety.
@hanrodz hanrodz added the enhancement New feature or request label Oct 30, 2024
@hanrodz hanrodz linked a pull request Nov 1, 2024 that will close this issue
Deduplicate localization code #14
Open
@hanrodz hanrodz self-assigned this Nov 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hanrodz hanrodz

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Deduplicate localization code guadalahacks/website
1 participant
@hanrodz