Skip to content

Commit ea8aa02

Browse files
authored
Merge branch 'guacsec:main' into scan_sbom_feature
2 parents 951d7cd + 16c0fc2 commit ea8aa02

File tree

4 files changed

+20
-5
lines changed

4 files changed

+20
-5
lines changed

client/openapi/trustd.yaml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4852,6 +4852,9 @@ components:
48524852
source:
48534853
type: string
48544854
description: The name of the quay registry, e.g. quay.io
4855+
unencrypted:
4856+
type: boolean
4857+
description: Whether the scheme used is 'http' [true] or 'https' [false]
48554858
RecommendEntry:
48564859
type: object
48574860
required:

client/src/app/pages/sbom-scan/components/UploadFileForAnalysis.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,10 +15,10 @@ import {
1515
ModalHeader,
1616
MultipleFileUpload,
1717
MultipleFileUploadMain,
18+
Spinner,
1819
} from "@patternfly/react-core";
1920

2021
import ExclamationCircleIcon from "@patternfly/react-icons/dist/esm/icons/exclamation-circle-icon";
21-
import InProgressIcon from "@patternfly/react-icons/dist/esm/icons/in-progress-icon";
2222
import TimesIcon from "@patternfly/react-icons/dist/esm/icons/times-icon";
2323
import UploadIcon from "@patternfly/react-icons/dist/esm/icons/upload-icon";
2424

@@ -143,7 +143,7 @@ export const UploadFileForAnalysis: React.FC<IUploadFileForAnalysisProps> = ({
143143
key={`${file.name}-${index}-progress`}
144144
headingLevel="h4"
145145
titleText={"Analyzing SBOM"}
146-
icon={InProgressIcon}
146+
icon={Spinner}
147147
variant={EmptyStateVariant.sm}
148148
>
149149
<EmptyStateBody>

client/src/app/pages/sbom-scan/components/VulnerabilityTable.tsx

Lines changed: 13 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -142,7 +142,7 @@ export const VulnerabilityTable: React.FC<IVulnerabilityTableProps> = ({
142142
placeholderText: "Severity",
143143
type: FilterType.multiselect,
144144
selectOptions: [
145-
{ value: "null", label: "Unknown" },
145+
{ value: "unknown", label: "Unknown" },
146146
{ value: "none", label: "None" },
147147
{ value: "low", label: "Low" },
148148
{ value: "medium", label: "Medium" },
@@ -295,6 +295,18 @@ export const VulnerabilityTable: React.FC<IVulnerabilityTableProps> = ({
295295
) !== -1
296296
);
297297
})
298+
.sort(
299+
(
300+
[_advisoryKeyA, advisoryValueA],
301+
[_advisoryKeyB, advisoryValueB],
302+
) => {
303+
const scoreA =
304+
advisoryValueA.opinionatedScore?.value ?? 0;
305+
const scoreB =
306+
advisoryValueB.opinionatedScore?.value ?? 0;
307+
return scoreB - scoreA;
308+
},
309+
)
298310
.map(([advisoryKey, advisoryValue]) => (
299311
<Flex key={advisoryKey}>
300312
<FlexItem spacer={{ default: "spacerNone" }}>

client/src/app/pages/sbom-scan/sbom-scan.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,7 @@ import {
2222
ModalFooter,
2323
ModalHeader,
2424
PageSection,
25+
Spinner,
2526
Split,
2627
SplitItem,
2728
type MenuToggleElement,
@@ -30,7 +31,6 @@ import {
3031
import CheckCircleIcon from "@patternfly/react-icons/dist/esm/icons/check-circle-icon";
3132
import DownloadIcon from "@patternfly/react-icons/dist/esm/icons/download-icon";
3233
import ExclamationCircleIcon from "@patternfly/react-icons/dist/esm/icons/exclamation-circle-icon";
33-
import InProgressIcon from "@patternfly/react-icons/dist/esm/icons/in-progress-icon";
3434
import TimesIcon from "@patternfly/react-icons/dist/esm/icons/times-icon";
3535

3636
import type { ExtractResult } from "@app/client";
@@ -198,7 +198,7 @@ export const SbomScan: React.FC = () => {
198198
<EmptyState
199199
titleText="Generating vulnerability report"
200200
headingLevel="h4"
201-
icon={InProgressIcon}
201+
icon={Spinner}
202202
>
203203
<EmptyStateBody>
204204
Analyzing your SBOM for security vulnerabilities and package

0 commit comments

Comments
 (0)