Refactoring reusable, removing unwanted await and comments

Signed-off-by: mrrajan <[email protected].>

Author: mrrajan

biome.json

@@ -41,7 +41,7 @@
       "!**/node_modules",
       "!client/coverage",
       "!client/src/app/client",
-      "!**/common/assets/**"
+      "!**/common/assets"
     ]
   }
 }

e2e/tests/ui/pages/Table.ts

@@ -117,10 +117,10 @@ export class Table {
    * @returns A locator for all matching rows
    * @example
    * // Get rows where Name column contains "curl"
-   * const rows = await table.getRowsByCellValue({ "Name": "curl" });
+   * const rows = table.getRowsByCellValue({ "Name": "curl" });
    *
    * // Get rows matching multiple criteria
-   * const rows = await table.getRowsByCellValue({ "Name": "curl", "Version": "7.29.0" });
+   * const rows = table.getRowsByCellValue({ "Name": "curl", "Version": "7.29.0" });
    */
   getRowsByCellValue(cellValues: Record<string, string>): Locator {
     // Start with all table rows

e2e/tests/ui/pages/package-details/PackageDetailsPage.ts

@@ -10,7 +10,10 @@ export class PackageDetailsPage {
     this._layout = layout;
   }
 
-  static async build(page: Page, packageDetail: Record<string, string>) {
+  static async build(
+    page: Page,
+    packageDetail: { Name: string; Version?: string },
+  ) {
     const navigation = await Navigation.build(page);
     await navigation.goToSidebar("Packages");
 

e2e/tests/ui/pages/package-details/sboms/SbomsTab.ts

@@ -14,7 +14,10 @@ export class SbomsTab {
   }
 
   static async build(page: Page, packageDetail: Record<string, string>) {
-    const detailsPage = await PackageDetailsPage.build(page, packageDetail);
+    const detailsPage = await PackageDetailsPage.build(page, {
+      Name: packageDetail.Name,
+      Version: packageDetail.Version,
+    });
     await detailsPage._layout.selectTab("SBOMs using package");
 
     return new SbomsTab(page, detailsPage);

e2e/tests/ui/pages/package-details/sboms/columns.spec.ts

@@ -11,7 +11,6 @@ test.describe("Columns validations", { tag: "@tier1" }, () => {
     await login(page);
   });
 
-  //here
   test("Columns", async ({ page }) => {
     const sbomTab = await SbomsTab.build(page, {
       Name: "keycloak-core",

e2e/tests/ui/pages/package-details/sboms/pagination.spec.ts

@@ -11,14 +11,18 @@ test.describe.skip("Pagination validations", { tag: "@tier1" }, () => {
   });
 
   test("Navigation button validations", async ({ page }) => {
-    const sbomTab = await SbomsTab.build(page, "keycloak-core");
+    const sbomTab = await SbomsTab.build(page, {
+      Name: "keycloak-core",
+    });
     const pagination = await sbomTab.getPagination();
 
     await pagination.validatePagination();
   });
 
   test("Items per page validations", async ({ page }) => {
-    const sbomTab = await SbomsTab.build(page, "keycloak-core");
+    const sbomTab = await SbomsTab.build(page, {
+      Name: "keycloak-core",
+    });
 
     const pagination = await sbomTab.getPagination();
     const table = await sbomTab.getTable();

e2e/tests/ui/pages/package-details/sboms/sort.spec.ts

@@ -10,7 +10,6 @@ test.describe("Sort validations", { tag: "@tier1" }, () => {
     await login(page);
   });
 
-  //here
   test("Sort", async ({ page }) => {
     const sbomTab = await SbomsTab.build(page, {
       Name: "keycloak-core",

e2e/tests/ui/pages/package-details/vulnerabilities/VulnerabilitiesTab.ts

@@ -14,7 +14,10 @@ export class VulnerabilitiesTab {
   }
 
   static async build(page: Page, packageDetail: Record<string, string>) {
-    const detailsPage = await PackageDetailsPage.build(page, packageDetail);
+    const detailsPage = await PackageDetailsPage.build(page, {
+      Name: packageDetail.Name,
+      Version: packageDetail.Version,
+    });
     await detailsPage._layout.selectTab("Vulnerabilities");
 
     return new VulnerabilitiesTab(page, detailsPage);

e2e/tests/ui/pages/package-details/vulnerabilities/columns.spec.ts

@@ -11,7 +11,6 @@ test.describe("Columns validations", { tag: "@tier1" }, () => {
     await login(page);
   });
 
-  //here
   test("Columns", async ({ page }) => {
     const vulnerabilitiesTab = await VulnerabilitiesTab.build(page, {
       Name: "keycloak-core",

e2e/tests/ui/pages/package-details/vulnerabilities/pagination.spec.ts

@@ -11,20 +11,18 @@ test.describe.skip("Pagination validations", { tag: "@tier1" }, () => {
   });
 
   test("Navigation button validations", async ({ page }) => {
-    const vulnerabilitiesTab = await VulnerabilitiesTab.build(
-      page,
-      "keycloak-core",
-    );
+    const vulnerabilitiesTab = await VulnerabilitiesTab.build(page, {
+      Name: "keycloak-core",
+    });
     const pagination = await vulnerabilitiesTab.getPagination();
 
     await pagination.validatePagination();
   });
 
   test("Items per page validations", async ({ page }) => {
-    const vulnerabilitiesTab = await VulnerabilitiesTab.build(
-      page,
-      "keycloak-core",
-    );
+    const vulnerabilitiesTab = await VulnerabilitiesTab.build(page, {
+      Name: "keycloak-core",
+    });
 
     const pagination = await vulnerabilitiesTab.getPagination();
     const table = await vulnerabilitiesTab.getTable();