feat: separate Red Hat and Community profiles for HTML report #522
Conversation
soul2zimate
force-pushed
the
html_report_main
branch
from
cdf0663 to
2478217
Compare
soul2zimate
force-pushed
the
html_report_main
branch
from
2478217 to
0d9d642
Compare
ruromero
left a comment
ruromero
left a comment
There was a problem hiding this comment.
It is the right approach but let's make it more generic and move the brandingConfig to the ReportTemplate.java
soul2zimate
force-pushed
the
html_report_main
branch
from
507681f to
cc10296
Compare
|
@ruromero I have updated according to your comments and added the back-end general solution too. Could you review again ? thanks. |
soul2zimate
force-pushed
the
html_report_main
branch
from
cc10296 to
07d3764
Compare
ruromero
left a comment
ruromero
left a comment
There was a problem hiding this comment.
I haven't added a comment in each place where Red Hat is mentioned but it should be deleted everywhere.
The use of the icon should allow any arbitrary icon and we will override it in the private project that we will deploy in the cloud.
Also don't repeat the default values each time.
src/main/java/io/github/guacsec/trustifyda/integration/report/ReportTemplate.java
Outdated
Show resolved
Hide resolved
soul2zimate
force-pushed
the
html_report_main
branch
from
07d3764 to
638a314
Compare
soul2zimate
force-pushed
the
html_report_main
branch
from
638a314 to
bfaf296
Compare
ruromero
left a comment
ruromero
left a comment
There was a problem hiding this comment.
Thanks for all the changes. Some small remarks and suggestions.
src/main/java/io/github/guacsec/trustifyda/integration/report/ReportTemplate.java
Outdated
Show resolved
Hide resolved
src/main/java/io/github/guacsec/trustifyda/integration/report/ReportTemplate.java
Outdated
Show resolved
Hide resolved
soul2zimate
force-pushed
the
html_report_main
branch
from
c9ea1f1 to
f55ff1b
Compare
|
I misunderstood the requirement. Now I
Please review again. Thanks. |
soul2zimate
force-pushed
the
html_report_main
branch
from
712c43e to
fc4470b
Compare
…ngConfig and update README
soul2zimate
force-pushed
the
html_report_main
branch
from
fc4470b to
7e953a5
Compare
ruromero
left a comment
ruromero
left a comment
There was a problem hiding this comment.
I just realized about the imageRecommendationLink.
Also please make sure you validate all the cases and properties in your local development before merging.
- Icon and properties customization, overrides
- Image text and links
src/test/java/io/github/guacsec/trustifyda/integration/HtmlReportTest.java
Show resolved
Hide resolved
fix: add imageRemediationLink fix: adapt HtmlReportTest by adding imageRecommend and imageRemediationLink to test configuration
ruromero
left a comment
ruromero
left a comment
There was a problem hiding this comment.
I think all the points are now addressed. Thank you
|
Thank you for patiently reviewing. |
2 participants
feat: separate Red Hat and Community profiles for HTML report
fixes: #523
The community version HTML report is like:
Hi @ruromero, I am making this draft PR to review, of course we might choose other approach.