Allow chaining expressions with Closure objects

Author: jf2048

examples/expressions/main.rs

@@ -1,6 +1,8 @@
 mod metadata;
 mod note;
 
+use glib::closure;
+
 use gtk::gio;
 use gtk::glib;
 use gtk::prelude::*;
@@ -48,11 +50,12 @@ fn build_ui(app: &gtk::Application) {
 
         metadata_expression
             .chain_property::<Metadata>("last-modified")
-            .chain_closure(|args| {
-                let last_modified: glib::DateTime = args[1].get().unwrap();
-                format!("Last Modified: {}", last_modified.format_iso8601().unwrap())
-            })
-            .bind(&last_modified_label, "label", gtk::Widget::NONE);
+            .chain_closure_obj::<String>(closure!(
+                |_: gtk::ListItem, last_modified: glib::DateTime| {
+                    format!("Last Modified: {}", last_modified.format_iso8601().unwrap())
+                }
+            ))
+            .bind(&last_modified_label, "label", Some(list_item));
 
         list_item.set_child(Some(&hbox));
     });

gtk4/src/closure_expression.rs

@@ -23,16 +23,13 @@ define_expression!(
 
 impl ClosureExpression {
     #[doc(alias = "gtk_closure_expression_new")]
-    pub fn new<F, R>(params: impl IntoIterator<Item = impl AsRef<Expression>>, callback: F) -> Self
+    pub fn new<R, I, E>(params: I, closure: glib::RustClosure) -> Self
     where
-        F: Fn(&[Value]) -> R + 'static,
         R: ValueType,
+        I: IntoIterator<Item = E>,
+        E: AsRef<Expression>,
     {
         assert_initialized_main_thread!();
-        let closure = glib::Closure::new_local(move |values| {
-            let ret = callback(values);
-            Some(ret.to_value())
-        });
 
         let params = params
             .into_iter()
@@ -42,21 +39,27 @@ impl ClosureExpression {
         unsafe {
             from_glib_full(ffi::gtk_closure_expression_new(
                 R::Type::static_type().into_glib(),
-                closure.to_glib_none().0,
+                closure.as_ref().to_glib_none().0,
                 params.len() as u32,
                 params.to_glib_full(),
             ))
         }
     }
 
     #[doc(alias = "gtk_closure_expression_new")]
-    pub fn with_closure<R, I, E>(params: I, closure: glib::Closure) -> Self
+    pub fn with_callback<F, R>(
+        params: impl IntoIterator<Item = impl AsRef<Expression>>,
+        callback: F,
+    ) -> Self
     where
+        F: Fn(&[Value]) -> R + 'static,
         R: ValueType,
-        I: IntoIterator<Item = E>,
-        E: AsRef<Expression>,
     {
         assert_initialized_main_thread!();
+        let closure = glib::Closure::new_local(move |values| {
+            let ret = callback(values);
+            Some(ret.to_value())
+        });
 
         let params = params
             .into_iter()

gtk4/src/expression.rs

@@ -171,14 +171,47 @@ impl Expression {
     }
 
     // rustdoc-stripper-ignore-next
-    /// Create a [`gtk::ClosureExpression`] with self as a parameter. This is useful in long
-    /// chains of [`gtk::Expression`]s.
-    pub fn chain_closure<F, R>(&self, f: F) -> crate::ClosureExpression
+    /// Create a [`ClosureExpression`](crate::ClosureExpression) from a [`glib::Closure`] with self
+    /// as the second parameter and `R` as the return type. The return type is checked at run-time
+    /// and must always be specified. This is useful in long chains of
+    /// [`Expression`](crate::Expression)s when using the [`glib::closure!`] macro.
+    ///
+    /// Note that the first parameter will always be the `this` object bound to the expression. If
+    /// `None` is passed as `this` then the type of the first parameter must be
+    /// `Option<glib::Object>` otherwise type checking will panic.
+    ///
+    /// ```no_run
+    /// # use gtk4 as gtk;
+    /// use gtk::prelude::*;
+    /// use gtk::glib;
+    /// use glib::{closure, Object};
+    ///
+    /// let button = gtk::Button::new();
+    /// button.set_label("Hello");
+    /// let label = button
+    ///     .property_expression("label")
+    ///     .chain_closure::<String>(closure!(|_: Option<Object>, label: &str| {
+    ///         format!("{} World", label)
+    ///     }))
+    ///     .evaluate_as::<String, _>(gtk::Widget::NONE);
+    /// assert_eq!(label.unwrap(), "Hello World");
+    /// ```
+    pub fn chain_closure<R>(&self, closure: glib::RustClosure) -> crate::ClosureExpression
+    where
+        R: glib::value::ValueType,
+    {
+        crate::ClosureExpression::new::<R, _, _>(&[self], closure)
+    }
+
+    // rustdoc-stripper-ignore-next
+    /// Create a [`ClosureExpression`](crate::ClosureExpression) with self as the second parameter.
+    /// This is useful in long chains of [`Expression`](crate::Expression)s.
+    pub fn chain_closure_with_callback<F, R>(&self, f: F) -> crate::ClosureExpression
     where
         F: Fn(&[glib::Value]) -> R + 'static,
         R: glib::value::ValueType,
     {
-        crate::ClosureExpression::new(&[self], f)
+        crate::ClosureExpression::with_callback(&[self], f)
     }
 }