okhttp: Assert no pending streams before transport READY (#12566)

becomeStar · web-flow · commit ed6d175fccf2 · 2025-12-16T18:48:03.000+05:30
### What this PR does Based on guidance from maintainers and what I have observed in the OkHttpClientTransport lifecycle, it seems that no pending streams should exist when the transport transitions to READY. This PR adds an assertion to help verify this invariant. --- ### Note on Testing All existing tests pass with this assertion in place. --- This PR corresponds to **Step 2** of the plan discussed in #11985, by adding an explicit assertion to help ensure the transport readiness invariant. Fixes #11985
diff --git a/okhttp/src/main/java/io/grpc/okhttp/OkHttpClientTransport.java b/okhttp/src/main/java/io/grpc/okhttp/OkHttpClientTransport.java
@@ -802,7 +802,9 @@ public void run() {
         }
         synchronized (lock) {
           maxConcurrentStreams = Integer.MAX_VALUE;
-          startPendingStreams();
+          checkState(pendingStreams.isEmpty(),
+              "Pending streams detected during transport start."
+                  + " RPCs should not be started before transport is ready.");
         }
         // ClientFrameHandler need to be started after connectionPreface / settings, otherwise it
         // may send goAway immediately.

Original file line number	Diff line number	Diff line change
`@@ -802,7 +802,9 @@ public void run() {`
`802`	`802`	`}`
`803`	`803`	`synchronized (lock) {`
`804`	`804`	`maxConcurrentStreams = Integer.MAX_VALUE;`
`805`		`- startPendingStreams();`
	`805`	`+ checkState(pendingStreams.isEmpty(),`
	`806`	`+ "Pending streams detected during transport start."`
	`807`	`+ + " RPCs should not be started before transport is ready.");`
`806`	`808`	`}`
`807`	`809`	`// ClientFrameHandler need to be started after connectionPreface / settings, otherwise it`
`808`	`810`	`// may send goAway immediately.`